Re: [Qemu-devel] [PATCH v4 5/5] aio: fix assert when remove poll during destroy

[Stefan Hajnoczi]

On Thu, Sep 28, 2017 at 10:59:58AM +0800, Peter Xu wrote:
> From: Stefan Hajnoczi <address@hidden>
> 
> After iothread is enabled internally inside QEMU with GMainContext, we
> may encounter this warning when destroying the iothread:
> 
> (qemu-system-x86_64:19925): GLib-CRITICAL **: g_source_remove_poll:
>  assertion '!SOURCE_DESTROYED (source)' failed
> 
> The problem is that g_source_remove_poll() does not allow to remove one
> source from array if the source is detached from its owner
> context. (peterx: which IMHO does not make much sense)
> 
> Fix it on QEMU side by avoid calling g_source_remove_poll() if we know
> the object is during destruction, and we won't leak anything after all
> since the array will be gone soon cleanly even with that fd.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> [peterx: write the commit message]
> Signed-off-by: Peter Xu <address@hidden>
> ---
>  util/aio-posix.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>