[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via device_ad
|
From: |
David Hildenbrand |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via device_add |
|
Date: |
Thu, 28 Sep 2017 15:00:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 28.09.2017 08:01, Thomas Huth wrote:
> On 13.09.2017 15:24, David Hildenbrand wrote:
>> E.g. the following now works:
>> device_add host-s390-cpu,id=cpu1,core-id=1
>
> Hi David,
>
> FYI, this introduced a possibility to crash QEMU with the none machine:
>
> $ s390x-softmmu/qemu-system-s390x -M none -nographic
> QEMU 2.10.50 monitor - type 'help' for more information
> (qemu) device_add qemu-s390-cpu
> Segmentation fault (core dumped)
>
> Thomas
>
Interesting, x86 shields hotplug for none completely.
t460s: ~/git/qemu s390x_lap $ sudo qemu-system-x86_64 -M none -smp
1,maxcpus=4 -monitor stdio -Sqemu-system-x86_64: Number of SMP CPUs
requested (4) exceeds max CPUs supported by machine 'none' (1)
Will send a patch.
--
Thanks,
David
- Re: [Qemu-devel] [PATCH v5 11/22] s390x: allow only 1 CPU with TCG, (continued)
[Qemu-devel] [PATCH v5 12/22] target/s390x: set cpu->id for linux user when realizing, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 14/22] target/s390x: rename next_cpu_id to next_core_id, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 13/22] target/s390x: use "core-id" for cpu number/address/id handling, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 15/22] s390x: print CPU definitions in sorted order, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via device_add, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 17/22] s390x: CPU hot unplug via device_del cannot work for now, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 18/22] s390x: implement query-hotpluggable-cpus, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 19/22] s390x: get rid of cpu_states and use possible_cpus instead, David Hildenbrand, 2017/09/13
[Qemu-devel] [PATCH v5 20/22] s390x: get rid of cpu_s390x_create(), David Hildenbrand, 2017/09/13