[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all shell f
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all shell frontends |
|
Date: |
Thu, 28 Sep 2017 10:19:40 -0300 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Thu, Sep 28, 2017 at 11:15:47AM +0200, Lukáš Doktor wrote:
[...]
> > @@ -231,6 +239,7 @@ class PlotShell(object):
> >
> > def run(self, argv):
> > args = self._parser.parse_args(argv)
>
> This class is not inherited from the `BaseShell`, therefor it
> does not contain `init_logging` method. Apart from this it
> looks good.
Oops. I will fix this in v2. Thanks!
>
> > + self.init_logging(args)
> >
> > if len(args.reports) == 0:
> > print >>sys.stderr, "At least one report required"
> >
--
Eduardo