qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [RFC v2 04/22] qobject: let object_property_get_str() use n


From: Peter Xu
Subject: [Qemu-devel] [RFC v2 04/22] qobject: let object_property_get_str() use new API
Date: Fri, 29 Sep 2017 11:38:26 +0800

We can simplify object_property_get_str() using the new
qobject_get_try_str().

Signed-off-by: Peter Xu <address@hidden>
---
 qom/object.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/qom/object.c b/qom/object.c
index 6a7bd9257b..d76a0ee797 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1107,18 +1107,15 @@ char *object_property_get_str(Object *obj, const char 
*name,
                               Error **errp)
 {
     QObject *ret = object_property_get_qobject(obj, name, errp);
-    QString *qstring;
     char *retval;
 
     if (!ret) {
         return NULL;
     }
-    qstring = qobject_to_qstring(ret);
-    if (!qstring) {
+
+    retval = g_strdup(qobject_get_try_str(ret));
+    if (!retval) {
         error_setg(errp, QERR_INVALID_PARAMETER_TYPE, name, "string");
-        retval = NULL;
-    } else {
-        retval = g_strdup(qstring_get_str(qstring));
     }
 
     qobject_decref(ret);
-- 
2.13.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]