[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 9/9] tpm: Move tpm_cleanup() to right place
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v10 9/9] tpm: Move tpm_cleanup() to right place |
Date: |
Fri, 29 Sep 2017 14:16:21 +0200 |
On Fri, Sep 29, 2017 at 1:10 PM, Amarnath Valluri
<address@hidden> wrote:
> As Emulator TPM backend uses chardev, tpm cleanup should happen before chardev
> similar to other vhost-users.
>
> Signed-off-by: Amarnath Valluri <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> tpm.c | 1 -
> vl.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tpm.c b/tpm.c
> index 3b8c7ed..3122227 100644
> --- a/tpm.c
> +++ b/tpm.c
> @@ -172,7 +172,6 @@ int tpm_init(void)
> return -1;
> }
>
> - atexit(tpm_cleanup);
> return 0;
> }
>
> diff --git a/vl.c b/vl.c
> index 9bb5058..ed86209 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4893,6 +4893,7 @@ int main(int argc, char **argv, char **envp)
> res_free();
>
> /* vhost-user must be cleaned up before chardevs. */
> + tpm_cleanup();
> net_cleanup();
> audio_cleanup();
> monitor_cleanup();
> --
> 2.7.4
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH v10 0/9] Provide support for the software TPM, Amarnath Valluri, 2017/09/29
- [Qemu-devel] [PATCH v10 1/9] tpm-backend: Remove unneeded member variable from backend class, Amarnath Valluri, 2017/09/29
- [Qemu-devel] [PATCH v10 3/9] tpm-backend: Initialize and free data members in it's own methods, Amarnath Valluri, 2017/09/29
- [Qemu-devel] [PATCH v10 4/9] tpm-backend: Made few interface methods optional, Amarnath Valluri, 2017/09/29
- [Qemu-devel] [PATCH v10 2/9] tpm-backend: Move thread handling inside TPMBackend, Amarnath Valluri, 2017/09/29
- [Qemu-devel] [PATCH v10 6/9] tpm-backend: Move realloc_buffer() implementation to tpm-tis model, Amarnath Valluri, 2017/09/29
- [Qemu-devel] [PATCH v10 5/9] tpm backend: Add new api to read backend TpmInfo, Amarnath Valluri, 2017/09/29
- [Qemu-devel] [PATCH v10 7/9] tpm-passthrough: move reusable code to utils, Amarnath Valluri, 2017/09/29
- [Qemu-devel] [PATCH v10 9/9] tpm: Move tpm_cleanup() to right place, Amarnath Valluri, 2017/09/29
- Re: [Qemu-devel] [PATCH v10 9/9] tpm: Move tpm_cleanup() to right place,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v10 8/9] tpm: Added support for TPM emulator, Amarnath Valluri, 2017/09/29