[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] websock: treat upgrade header in case insen
|
From: |
Denis V. Lunev |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] websock: treat upgrade header in case insensitive way |
|
Date: |
Fri, 29 Sep 2017 20:07:34 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/29/2017 07:19 PM, Daniel P. Berrange wrote:
> On Fri, Sep 29, 2017 at 05:56:29PM +0300, Denis V. Lunev wrote:
>> According to rfc6455 section 4.2.1. Reading the Client's Opening Handshake
>> An |Upgrade| header field containing the value "websocket",
>> treated as an ASCII case-insensitive value.
>>
>> Current implementation in QEMU accepts this header in lower-case only,
>> which is revealed to have broken some real-life clients. We need to
>> convert the value of this header to lower case before comparison.
>> Unfortunately we can not do that for all headers. Only this specific one
>> should be converted this way.
>>
>> Signed-off-by: Denis V. Lunev <address@hidden>
>> CC: Daniel P. Berrange <address@hidden>
> FYI, I already have a fix for this problem queued:
>
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02982.html
>
>
> Regards,
> Daniel
cool, thanks