[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 41/47] hw/watchdog: Replace fprintf(stderr, "*\n"
From: |
Alistair Francis |
Subject: |
[Qemu-devel] [PATCH v2 41/47] hw/watchdog: Replace fprintf(stderr, "*\n" with error_report() |
Date: |
Fri, 29 Sep 2017 17:17:06 -0700 |
Replace a large number of the fprintf(stderr, "*\n" calls with
error_report(). The functions were renamed with these commands and then
compiler issues where manually fixed.
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr,
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N;N; {s|fprintf(stderr,
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N;N;N; {s|fprintf(stderr,
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N;N; {s|fprintf(stderr,
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N;N; {s|fprintf(stderr,
"\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}'
\
{} +
find ./* -type f -exec sed -i \
'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
find ./* -type f -exec sed -i \
'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \
{} +
Some lines where then manually tweaked to pass checkpatch.
Signed-off-by: Alistair Francis <address@hidden>
---
V2:
- Split hw patch into individual directories
hw/watchdog/watchdog.c | 9 +++++----
hw/watchdog/wdt_i6300esb.c | 8 +++++---
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/hw/watchdog/watchdog.c b/hw/watchdog/watchdog.c
index 0c5c9cde1c..76ae5d2fe5 100644
--- a/hw/watchdog/watchdog.c
+++ b/hw/watchdog/watchdog.c
@@ -20,6 +20,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/error-report.h"
#include "qemu/option.h"
#include "qemu/config-file.h"
#include "qemu/queue.h"
@@ -51,7 +52,7 @@ int select_watchdog(const char *p)
/* -watchdog ? lists available devices and exits cleanly. */
if (is_help_option(p)) {
QLIST_FOREACH(model, &watchdog_list, entry) {
- fprintf(stderr, "\t%s\t%s\n",
+ error_report("\t%s\t%s",
model->wdt_name, model->wdt_description);
}
return 2;
@@ -67,9 +68,9 @@ int select_watchdog(const char *p)
}
}
- fprintf(stderr, "Unknown -watchdog device. Supported devices are:\n");
+ error_report("Unknown -watchdog device. Supported devices are:");
QLIST_FOREACH(model, &watchdog_list, entry) {
- fprintf(stderr, "\t%s\t%s\n",
+ error_report("\t%s\t%s",
model->wdt_name, model->wdt_description);
}
return 1;
@@ -133,7 +134,7 @@ void watchdog_perform_action(void)
case WDT_DEBUG:
qapi_event_send_watchdog(WATCHDOG_EXPIRATION_ACTION_DEBUG,
&error_abort);
- fprintf(stderr, "watchdog: timer fired\n");
+ error_report("watchdog: timer fired");
break;
case WDT_NONE:
diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
index 49b3cd188a..f596f70a3b 100644
--- a/hw/watchdog/wdt_i6300esb.c
+++ b/hw/watchdog/wdt_i6300esb.c
@@ -20,7 +20,7 @@
*/
#include "qemu/osdep.h"
-
+#include "qemu/error-report.h"
#include "qemu-common.h"
#include "qemu/timer.h"
#include "sysemu/watchdog.h"
@@ -186,10 +186,12 @@ static void i6300esb_timer_expired(void *vp)
/* What to do at the end of stage 1? */
switch (d->int_type) {
case INT_TYPE_IRQ:
- fprintf(stderr, "i6300esb_timer_expired: I would send APIC 1 INT
10 here if I knew how (XXX)\n");
+ error_report("i6300esb_timer_expired: I would send APIC 1 INT 10"
+ "here if I knew how (XXX)");
break;
case INT_TYPE_SMI:
- fprintf(stderr, "i6300esb_timer_expired: I would send SMI here if
I knew how (XXX)\n");
+ error_report("i6300esb_timer_expired: I would send SMI here if I"
+ "knew how (XXX)");
break;
}
--
2.11.0
- [Qemu-devel] [PATCH v2 32/47] hw/ppc: Replace fprintf(stderr, "*\n" with error_report(), (continued)
- [Qemu-devel] [PATCH v2 32/47] hw/ppc: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 36/47] hw/sh4: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 34/47] hw/scsi: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 33/47] hw/s390x: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 39/47] hw/timer: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 38/47] hw/ssi: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 37/47] hw/sparc*: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 41/47] hw/watchdog: Replace fprintf(stderr, "*\n" with error_report(),
Alistair Francis <=
- [Qemu-devel] [PATCH v2 40/47] hw/usb: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 44/47] ui: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 45/47] tcg: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 42/47] hw/xen*: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 43/47] util: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 46/47] target: Use qemu_log() instead of fprintf(stderr, ...), Alistair Francis, 2017/09/29
- [Qemu-devel] [PATCH v2 47/47] target: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/29