[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/mips: remove commented out codes intran
From: |
jiang.biao2 |
Subject: |
Re: [Qemu-devel] [PATCH] target/mips: remove commented out codes intranslate.c |
Date: |
Sat, 30 Sep 2017 08:38:06 +0800 (CST) |
> On 29/09/2017 10:58, Philippe Mathieu-Daudé wrote:
> > Hi Jiang,
> >
> > I'm not sure it is really helpful to remove those comment, they are here as
> > debt to the project, reminding what should be implemented.
> >
> > Are you proposing to accept this instructions will never get implemented?
> >
> > Regards,
> >
> > Phil.
>>
>
> Hi Phil,
>
> The commented codes are all trivial. When the time we implement those
> features it is merely copy & paste from the specification. I don't think
> there is much harm to remove the comments.
> Besides there is TODO file in the same directory but that has not been
> updated for a while, perhaps updating the file is much relevant with this
> patch.
Can't agree more :), it should be better put the reminder in other place
rather in release code.
Regards,
Jiang
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] target/mips: remove commented out codes intranslate.c,
jiang.biao2 <=