Re: [Qemu-devel] [RFC PATCH] tests/tcg: add write tests for nbyte = 0

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH] tests/tcg: add write tests for nbyte = 0

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e1a45b2a8f tests/tcg: add write tests for nbyte = 0

=== OUTPUT BEGIN ===
Checking PATCH 1/1: tests/tcg: add write tests for nbyte = 0...
ERROR: braces {} are necessary for all arms of this statement
#103: FILE: tests/tcg/linux-test.c:112:
+    if (len != 0)
[...]

ERROR: braces {} are necessary for all arms of this statement
#106: FILE: tests/tcg/linux-test.c:115:
+    if (len != 0)
[...]

ERROR: code indent should never use tabs
#107: FILE: tests/tcg/linux-test.c:116:
+^Ierror("write NULL buf");$

ERROR: do not use C99 // comments
#116: FILE: tests/tcg/linux-test.c:543:
+    //test_signal();

total: 4 errors, 0 warnings, 72 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden