Re: [Qemu-devel] [PATCH 29/38] sparc: cleanup cpu type name composition

[Philippe Mathieu-Daudé]

On 10/02/2017 06:08 AM, Igor Mammedov wrote:
> introduce SPARC_CPU_TYPE_NAME macro and use it to
> construct cpu type names.
>
> Signed-off-by: Igor Mammedov <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

> ---
> macro will also be used in follow up patches to define
> default cpu types per board
>
> CC: address@hidden
> CC: address@hidden
> ---
>   target/sparc/cpu.h | 3 +++
>   target/sparc/cpu.c | 2 +-
>   2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h
> index 1598f65..7aa45c9 100644
> --- a/target/sparc/cpu.h
> +++ b/target/sparc/cpu.h
> @@ -658,6 +658,9 @@ int cpu_sparc_signal_handler(int host_signum, void *pinfo, 
> void *puc);
>   #define cpu_init(cpu_model) cpu_generic_init(TYPE_SPARC_CPU, cpu_model)
>   #endif
>   
> +#define SPARC_CPU_TYPE_SUFFIX "-" TYPE_SPARC_CPU
> +#define SPARC_CPU_TYPE_NAME(model) model SPARC_CPU_TYPE_SUFFIX
> +
>   #define cpu_signal_handler cpu_sparc_signal_handler
>   #define cpu_list sparc_cpu_list
>   
> diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
> index beab90f..f09ba50 100644
> --- a/target/sparc/cpu.c
> +++ b/target/sparc/cpu.c
> @@ -712,7 +712,7 @@ static bool sparc_cpu_has_work(CPUState *cs)
>   
>   static char *sparc_cpu_type_name(const char *cpu_model)
>   {
> -    char *name = g_strdup_printf("%s-" TYPE_SPARC_CPU, cpu_model);
> +    char *name = g_strdup_printf(SPARC_CPU_TYPE_NAME("%s"), cpu_model);
>       char *s = name;
>   
>       /* SPARC cpu model names happen to have whitespaces,