[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/gen_pcie_root_port: properly set
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH] hw/gen_pcie_root_port: properly set |
Date: |
Mon, 2 Oct 2017 23:49:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/02/17 12:31, Marcel Apfelbaum wrote:
> IO_LIMIT and IO_BASE registers should not be writable if
> gen_pcie_root_port's io-reserve property is set to 0.
> The COMMAND register should have the IO flag read only.
>
>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
> hw/pci-bridge/gen_pcie_root_port.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/hw/pci-bridge/gen_pcie_root_port.c
> b/hw/pci-bridge/gen_pcie_root_port.c
> index ed03ffc764..ad4e6aa7ff 100644
> --- a/hw/pci-bridge/gen_pcie_root_port.c
> +++ b/hw/pci-bridge/gen_pcie_root_port.c
> @@ -85,6 +85,13 @@ static void gen_rp_realize(DeviceState *dev, Error **errp)
> rpc->parent_class.exit(d);
> return;
> }
> +
> + if (!grp->io_reserve) {
> + pci_word_test_and_clear_mask(d->wmask + PCI_COMMAND,
> + PCI_COMMAND_IO);
> + d->wmask[PCI_IO_BASE] = 0;
> + d->wmask[PCI_IO_LIMIT] = 0;
> + }
> }
>
> static const VMStateDescription vmstate_rp_dev = {
>
The patch looks good to me (which doesn't mean much, honestly :) ), but
I think the subject line is truncated. You left off what exactly should
be set properly. (IO base, IO limit, and command registers, presumably.)
Thanks!
Laszlo