Re: [Qemu-devel] [PATCH v2 18/47] hw/intc: Replace fprintf(stderr, "*\n" with error_report()

[Cornelia Huck]

On Fri, 29 Sep 2017 17:15:54 -0700
Alistair Francis <address@hidden> wrote:

> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.

> diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic_kvm.c
> index d208cb81c4..e710bfdcda 100644
> --- a/hw/intc/s390_flic_kvm.c
> +++ b/hw/intc/s390_flic_kvm.c
> @@ -83,7 +83,7 @@ static void flic_enable_pfault(KVMS390FLICState *flic)
>      rc = ioctl(flic->fd, KVM_SET_DEVICE_ATTR, &attr);
>  
>      if (rc) {
> -        fprintf(stderr, "flic: couldn't enable pfault\n");
> +        error_report("flic: couldn't enable pfault");
>      }
>  }
>  
> @@ -97,7 +97,7 @@ static void flic_disable_wait_pfault(KVMS390FLICState *flic)
>      rc = ioctl(flic->fd, KVM_SET_DEVICE_ATTR, &attr);
>  
>      if (rc) {
> -        fprintf(stderr, "flic: couldn't disable pfault\n");
> +        error_report("flic: couldn't disable pfault");
>      }
>  }
>  

s390x part:

Acked-by: Cornelia Huck <address@hidden>