[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/8] qemu-options: Move -iscsi under "Block devi
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 4/8] qemu-options: Move -iscsi under "Block device options" |
Date: |
Wed, 4 Oct 2017 12:12:51 +0200 |
On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster <address@hidden> wrote:
> -iscsi ended up under the "Device URL Syntax" heading by a sequence of
> errors, as explained in the previous commit. Move it under the "Block
> device options" heading. Nothing left under "Device URL Syntax";
> drop the heading.
>
> Cc: Ronnie Sahlberg <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> Cc: address@hidden
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> qemu-options.hx | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index f112281d37..c647fdde62 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1172,6 +1172,13 @@ STEXI
> Create synthetic file system image
> ETEXI
>
> +DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
> + "-iscsi [user=user][,password=password]\n"
> + " [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n"
> + " [,initiator-name=initiator-iqn][,id=target-iqn]\n"
> + " [,timeout=timeout]\n"
> + " iSCSI session parameters\n", QEMU_ARCH_ALL)
> +
> STEXI
> @end table
> ETEXI
> @@ -2811,14 +2818,6 @@ STEXI
> ETEXI
> DEFHEADING()
>
> -DEFHEADING(Device URL Syntax:)
> -DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
> - "-iscsi [user=user][,password=password]\n"
> - " [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n"
> - " [,initiator-name=initiator-iqn][,id=target-iqn]\n"
> - " [,timeout=timeout]\n"
> - " iSCSI session parameters\n", QEMU_ARCH_ALL)
> -
> DEFHEADING(Bluetooth(R) options:)
> STEXI
> @table @option
> --
> 2.13.6
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH 7/8] qemu-options: Polish section "Character device options", (continued)