[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/11] qapi: Eliminate QAPISchemaParser.__init__
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 03/11] qapi: Eliminate QAPISchemaParser.__init__()'s local fname |
Date: |
Wed, 4 Oct 2017 12:15:57 +0200 |
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster <address@hidden> wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qapi.py | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index dc92bca620..6c8001e96d 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -261,8 +261,7 @@ class QAPISchemaParser(object):
>
> def __init__(self, fp, previously_included=[], incl_info=None):
> abs_fname = os.path.abspath(fp.name)
> - fname = fp.name
> - self.fname = fname
> + self.fname = fp.name
> previously_included.append(abs_fname)
> self.incl_info = incl_info
> self.src = fp.read()
> @@ -277,7 +276,7 @@ class QAPISchemaParser(object):
> self.accept()
>
> while self.tok is not None:
> - info = {'file': fname, 'line': self.line,
> + info = {'file': self.fname, 'line': self.line,
> 'parent': self.incl_info}
> if self.tok == '#':
> self.reject_expr_doc()
> --
> 2.13.6
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH 00/11] qapi: Cleanups around qapi2texi, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 04/11] qapi: Make cur_doc local to QAPISchemaParser.__init__(), Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 07/11] qapi: Unify representation of doc section without name, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 02/11] qapi: Stop rejecting #optional, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 03/11] qapi: Eliminate QAPISchemaParser.__init__()'s local fname, Markus Armbruster, 2017/10/02
- Re: [Qemu-devel] [PATCH 03/11] qapi: Eliminate QAPISchemaParser.__init__()'s local fname,
Marc-André Lureau <=
- [Qemu-devel] [PATCH 05/11] tests/qapi-schema/doc-bad-section: New, factored out of doc-good, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 06/11] qapi2texi: Clean up texi_sections(), Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 10/11] qapi: Rename QAPIDoc.parser, .section to ._parser, ._section, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 01/11] qapi-schema: Fix query-vm-generation-id's doc comment markup, Markus Armbruster, 2017/10/02