|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [Qemu-devel] nbd structured reply |
Date: | Thu, 5 Oct 2017 14:30:07 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
21.09.2017 15:18, Vladimir Sementsov-Ogievskiy wrote:
Hi all! I'm about this:"A server SHOULD try to minimize the number of chunks sent in a reply, but MUST NOT mark a chunk as final if there is still a possibility of detecting an error before transmission of that chunk completes"What do we mean by "possibility"? Formally, such possibility exists always, so, we'll never mark a chunk as final.
One more question:for |NBD_REPLY_TYPE_ERROR and ||NBD_REPLY_TYPE_ERROR_OFFSET, why do we need message_length field? why not to calc it as chunk.lenght - 4 for ||NBD_REPLY_TYPE_ERROR and chunk.lenght - 12 for ||NBD_REPLY_TYPE_ERROR_OFFSET?
For example, with NBD_REPLY_TYPE_OFFSET_DATA variable data length is calculated, not specified separately.
What is the reason for server to send NBD_REPLY_TYPE_ERROR with message_lenght < chunk.lenght - 4?
| -- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |