Re: [Qemu-devel] [PULL 0/6] Ui 20171005 patches

[Daniel P. Berrange]

On Thu, Oct 05, 2017 at 04:12:12PM +0100, Peter Maydell wrote:
> On 5 October 2017 at 11:01, Gerd Hoffmann <address@hidden> wrote:
> > The following changes since commit d147f7e815f97cb477e223586bcb80c316ae10ea:
> >
> >   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into 
> > staging (2017-10-03 16:27:24 +0100)
> >
> > are available in the git repository at:
> >
> >   git://git.kraxel.org/qemu tags/ui-20171005-pull-request
> >
> > for you to fetch changes up to 47247520ac44592cc7343138380bd6099f83262f:
> >
> >   ui: don't export qemu_input_event_new_key (2017-10-05 11:21:51 +0200)
> >
> > ----------------------------------------------------------------
> > ui: use keycodemapdb for key code mappings, part one
> >
> > ----------------------------------------------------------------
> 
> Fails to build, all platforms:
> 
> make: Entering directory `/home/pm215/qemu/build/all'
> config-host.mak is out-of-date, running configure
> make: *** No rule to make target `ui/input-keymap-linux-to-qcode.c',
> needed by `Makefile'. Stop.
> make: *** Waiting for unfinished jobs....
> Install prefix    /usr/local
> BIOS directory    /usr/local/share/qemu
> firmware path     /usr/local/share/qemu-firmware
> binary directory  /usr/local/bin
> library directory /usr/local/lib
> module directory  /usr/local/lib/qemu
> [etc]
> replication support yes
> VxHS block device no
> make: Leaving directory `/home/pm215/qemu/build/all'
> 
> That make complains about the missing .c file before it has
> finished running configure looks suspicious. I think there's
> a race here with parallel make.

Am I right in thinking from this snippet, that you applied the patch
series to an existing checkout with built files and then just did a
'make', as opposed todoing a git clean + configure + make sequence.

That would explain why this failed - the list of submodules is not
populated in the pre-existing config-host.mak. So we wouldn't checkout
the new submodules, and so the deps in the GENERATED_FILES list won't
be satisfied.  I'll figure out how to make this correctly cope with
gracefully upgrading from a dev's existing checkout...

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|