[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/22] tcg: tb_lock removal
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 00/22] tcg: tb_lock removal |
Date: |
Fri, 06 Oct 2017 11:56:21 +0100 |
User-agent: |
mu4e 0.9.19; emacs 26.0.60 |
Emilio G. Cota <address@hidden> writes:
> On Mon, Aug 07, 2017 at 19:52:16 -0400, Emilio G. Cota wrote:
>> This series applies on top of the "multiple TCG contexts" series, v4:
>> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg06769.html
> (snip)
>> Please review!
>
> Turns out this patchset breaks icount, even after fixing the patchset
> it is based on (see [1]).
Isn't icount only used in single-threaded mode though?
>
> The last good patch in the series is patch 10:
> "translate-all: work page-by-page in tb_invalidate_phys_range_1".
> I have no time to look into fixing that, so if you end up reviewing
> this set, please review only patches 1-10.
>
> The good news is that patches > 10 get really hairy, so this should
> reduce the review burden substantially.
>
> Thanks,
>
> Emilio
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg01198.html
--
Alex Bennée