[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] oslib-posix: Fix compiler warning
From: |
Stefan Weil |
Subject: |
[Qemu-devel] [PATCH] oslib-posix: Fix compiler warning |
Date: |
Sat, 7 Oct 2017 17:55:22 +0200 |
gcc warning:
/qemu/util/oslib-posix.c:304:11: error:
variable ‘addr’ might be clobbered by ‘longjmp’ or ‘vfork’
[-Werror=clobbered]
Use also an unsigned loop variable which better matches numpages.
Signed-off-by: Stefan Weil <address@hidden>
---
Please cc qemu-trivial if you think this is trivial enough.
Thanks,
Stefan
index 80086c549f..eb66a6f63c 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -301,11 +301,7 @@ static void sigbus_handler(int signal)
static void *do_touch_pages(void *arg)
{
MemsetThread *memset_args = (MemsetThread *)arg;
- char *addr = memset_args->addr;
- uint64_t numpages = memset_args->numpages;
- uint64_t hpagesize = memset_args->hpagesize;
sigset_t set, oldset;
- int i = 0;
/* unblock SIGBUS */
sigemptyset(&set);
@@ -315,6 +311,10 @@ static void *do_touch_pages(void *arg)
if (sigsetjmp(memset_args->env, 1)) {
memset_thread_failed = true;
} else {
+ char *addr = memset_args->addr;
+ uint64_t numpages = memset_args->numpages;
+ uint64_t hpagesize = memset_args->hpagesize;
+ unsigned i;
for (i = 0; i < numpages; i++) {
/*
* Read & write back the same value, so we don't
--
2.11.0
- [Qemu-devel] [PATCH] oslib-posix: Fix compiler warning,
Stefan Weil <=