[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] watchdog/aspeed: fix variable type to store
From: |
Andrew Jeffery |
Subject: |
Re: [Qemu-devel] [PATCH v2] watchdog/aspeed: fix variable type to store reload value |
Date: |
Mon, 09 Oct 2017 10:15:31 +1030 |
On Wed, 2017-09-20 at 08:49 +0200, Cédric Le Goater wrote:
> Initially from Anton D. Kachalov" <address@hidden> but the SoB was
> missing.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> [clg: change commit log and subject
> replace UL suffix by ULL ]
> Signed-off-by: Cédric Le Goater <address@hidden>
Acked-by: Andrew Jeffery <address@hidden>
> ---
> hw/watchdog/wdt_aspeed.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
> index 22bce364d7b5..95f6ad186d72 100644
> --- a/hw/watchdog/wdt_aspeed.c
> +++ b/hw/watchdog/wdt_aspeed.c
> @@ -100,13 +100,13 @@ static uint64_t aspeed_wdt_read(void *opaque, hwaddr
> offset, unsigned size)
>
> static void aspeed_wdt_reload(AspeedWDTState *s, bool pclk)
> {
> - uint32_t reload;
> + uint64_t reload;
>
> if (pclk) {
> reload = muldiv64(s->regs[WDT_RELOAD_VALUE], NANOSECONDS_PER_SECOND,
> s->pclk_freq);
> } else {
> - reload = s->regs[WDT_RELOAD_VALUE] * 1000;
> + reload = s->regs[WDT_RELOAD_VALUE] * 1000ULL;
> }
>
> if (aspeed_wdt_is_enabled(s)) {
signature.asc
Description: This is a digitally signed message part
- Re: [Qemu-devel] [PATCH v2] watchdog/aspeed: fix variable type to store reload value,
Andrew Jeffery <=