Re: [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads tests

[Peter Xu]

On Wed, Oct 04, 2017 at 12:39:32PM +0200, Juan Quintela wrote:

[...]

>  int main(int argc, char **argv)
>  {
> @@ -641,6 +689,9 @@ int main(int argc, char **argv)
>      qtest_add_func("/migration/precopy/tcp", test_precopy_tcp);
>      qtest_add_func("/migration/deprecated/unix", test_deprecated_unix);
>      qtest_add_func("/migration/xbzrle/unix", test_xbzrle_unix);

Nits: Not sure whether we can have better naming for the tests?  Say:

  /migration/precopy/unix
  /migration/precopy/tcp
  /migration/deprecated-cmds
  /migration/xbzrle
  /migration/compression

I'm fine with existing naming as well.

For the deprecated commands test, not sure whether we can just send
those commands and query using "query-migrate-parameters" to make sure
they are setup and valid.  I assume it can be faster than real
migrations.

> +    if (0) {

Is this intended? :)

> +        qtest_add_func("/migration/compress/unix", test_compress_unix);
> +    }
>  
>      ret = g_test_run();
>  
> -- 
> 2.13.5
> 

Thanks,

-- 
Peter Xu