[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 02/12] migration: Improve migration thread er
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [PATCH v9 02/12] migration: Improve migration thread error handling |
|
Date: |
Mon, 9 Oct 2017 17:28:38 +0800 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Oct 04, 2017 at 12:46:26PM +0200, Juan Quintela wrote:
[...]
> diff --git a/migration/tls.c b/migration/tls.c
> index 596e8790bd..026a008667 100644
> --- a/migration/tls.c
> +++ b/migration/tls.c
> @@ -119,7 +119,6 @@ static void migration_tls_outgoing_handshake(QIOTask
> *task,
> if (qio_task_propagate_error(task, &err)) {
> trace_migration_tls_outgoing_handshake_error(error_get_pretty(err));
> migrate_fd_error(s, err);
> - error_free(err);
Would err be leaked if this line is removed?
> } else {
> trace_migration_tls_outgoing_handshake_complete();
> migration_channel_connect(s, ioc, NULL);
> --
> 2.13.5
>
--
Peter Xu