Re: [Qemu-devel] [PATCH 03/42] tpm: make tpm_get_backend_driver() static

[Stefan Berger]

On 10/09/2017 06:55 PM, Marc-André Lureau wrote:
> No need to export the function.
>
> Signed-off-by: Marc-André Lureau <address@hidden>

Reviewed-by: Stefan Berger <address@hidden>


> ---
>   include/sysemu/tpm_backend.h | 1 -
>   tpm.c                        | 2 +-
>   2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/sysemu/tpm_backend.h b/include/sysemu/tpm_backend.h
> index 2c798a1eb4..c6e5637f68 100644
> --- a/include/sysemu/tpm_backend.h
> +++ b/include/sysemu/tpm_backend.h
> @@ -215,7 +215,6 @@ TPMInfo *tpm_backend_query_tpm(TPMBackend *s);
>
>   TPMBackend *qemu_find_tpm(const char *id);
>
> -const TPMDriverOps *tpm_get_backend_driver(const char *type);
>   void tpm_register_model(enum TpmModel model);
>   void tpm_register_driver(const TPMDriverOps *tdo);
>
> diff --git a/tpm.c b/tpm.c
> index 3122227156..bc7d7470a8 100644
> --- a/tpm.c
> +++ b/tpm.c
> @@ -31,7 +31,7 @@ void tpm_register_model(enum TpmModel model)
>       tpm_models[model] = true;
>   }
>
> -const TPMDriverOps *tpm_get_backend_driver(const char *type)
> +static const TPMDriverOps *tpm_get_backend_driver(const char *type)
>   {
>       int i = qapi_enum_parse(&TpmType_lookup, type, -1, NULL);