Re: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

[Martin Schrodt]

On 10/10/2017 08:18 PM, Eric Blake wrote:

> That's a lot of changes to be slamming in one patch.  Any chance you can
> split it into a series of smaller patches that are easier to review
> individually?  Perhaps one patch per item in your bulleted list is a
> good start for subdividing this into something that is not so massive.

I could make a separate request with all my commits separated.

The patch is all these squashed:

https://github.com/qemu/qemu/compare/master...spheenik:master

Problem is, and that's why I decided to hand it over like this, is that
the commits are kind of a log of my learning experience, getting to
this, and so not really separated better.

These 3 here are only paaudio.c

- Remove PA reader/writer threads from paaudio.c, and do IO from the
audio timer directly.
- Expose new configurable settings, such as TLENGTH and FRAGSIZE, plus
settings to
  enable PA_STREAM_ADJUST_LATENCY for input and output device separately.
- Fix the input delay when first using the input device.

and cannot really be separated, unfortunately.
The third one is really only a consequence of the removal of the
additional audio thread.

And this one:

- Add 1 millisecond timers which interface with the HDA device, pulling
and pushing data
  to and from it, to enable the guest driver to measure DMA timing by
just looking the LPIB registers.

is hda-codec.c.

Hope that helps,

Martin

signature.asc
Description: OpenPGP digital signature