Re: [Qemu-devel] [PATCH 35/42] tpm-tis: simplify header inclusion

[Stefan Berger]

On 10/09/2017 06:56 PM, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <address@hidden>

Reviewed-by: Stefan Berger <address@hidden>


> ---
>   hw/tpm/tpm_tis.c | 13 ++++---------
>   1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
> index 3c8d246ac8..e7e8b112e8 100644
> --- a/hw/tpm/tpm_tis.c
> +++ b/hw/tpm/tpm_tis.c
> @@ -24,17 +24,12 @@
>
>   #include "qemu/osdep.h"
>   #include "hw/isa/isa.h"
> -#include "sysemu/tpm_backend.h"
> -#include "tpm_int.h"
> -#include "sysemu/block-backend.h"
> -#include "exec/address-spaces.h"
> -#include "hw/hw.h"
> -#include "hw/i386/pc.h"
> -#include "hw/pci/pci_ids.h"
>   #include "qapi/error.h"
> -#include "qemu-common.h"
> -#include "qemu/main-loop.h"
> +
>   #include "hw/acpi/tpm.h"
> +#include "hw/pci/pci_ids.h"
> +#include "sysemu/tpm_backend.h"
> +#include "tpm_int.h"
>
>   #define TPM_TIS_NUM_LOCALITIES      5     /* per spec */
>   #define TPM_TIS_LOCALITY_SHIFT      12