Re: [Qemu-devel] [PULL v2 00/10] Merge tpm 2017/10/04

[Stefan Berger]

On 10/10/2017 11:08 AM, Peter Maydell wrote:
> On 10 October 2017 at 02:33, Stefan Berger <address@hidden> wrote:
> > The following changes since commit d147f7e815f97cb477e223586bcb80c316ae10ea:
> >
> >    Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into 
> > staging (2017-10-03 16:27:24 +0100)
> >
> > are available in the git repository at:
> >
> >    git://github.com/stefanberger/qemu-tpm.git tags/pull-tpm-2017-10-04-2
> >
> > for you to fetch changes up to 3bfc6666c21bf9e437734bb3e90db7e5b5f6b8bf:
> >
> >    specs: Describe the TPM support in QEMU (2017-10-05 12:50:45 -0400)
> >
> > ----------------------------------------------------------------
> > Merge tpm 2017/10/04 v2
> >
> > ----------------------------------------------------------------
> Hi. This fails to build, I'm afraid:
>
> On OpenBSD:

I installed OpenBSD 6.2 for i386 . I could recreate this one. PRIx64 
solves it. I don't see the EBADMSG.  We include qemu/osdep.h in this 
file, so this is odd.

    Stefan


>    CC      hw/tpm/tpm_emulator.o
> /home/qemu/hw/tpm/tpm_emulator.c: In function 'tpm_emulator_probe_caps':
> /home/qemu/hw/tpm/tpm_emulator.c:223:5: warning: format '%lx' expects
> argument of type 'long unsigned int', but argument 3 has type
> 'ptm_cap' [-Wformat=]
>       DPRINTF("capbilities : 0x%lx", tpm_emu->caps);
>       ^
> gmake: Leaving directory '/home/qemu/build/all'
> gmake: Entering directory '/home/qemu/build/all'
>    CC      hw/tpm/tpm_util.o
> /home/qemu/hw/tpm/tpm_util.c: In function 'tpm_util_test':
> /home/qemu/hw/tpm/tpm_util.c:94:16: error: 'EBADMSG' undeclared (first
> use in this function)
>           return EBADMSG;
>                  ^
> /home/qemu/hw/tpm/tpm_util.c:94:16: note: each undeclared identifier
> is reported only once for each function it appears in
>
> On AArch32:
>
> /home/peter.maydell/qemu/hw/tpm/tpm_emulator.c: In function
> 'tpm_emulator_probe_caps':
> /home/peter.maydell/qemu/hw/tpm/tpm_emulator.c:53:25: error: format
> '%lx' expects argument of type 'long unsigned int', but argument 3 has
> type 'ptm_cap {aka long long unsigned int}' [-Werror=format=]
>           fprintf(stderr, "tpm-emulator:"fmt"\n", ## __VA_ARGS__); \
>                           ^
> /home/peter.maydell/qemu/hw/tpm/tpm_emulator.c:223:5: note: in
> expansion of macro 'DPRINTF'
>       DPRINTF("capbilities : 0x%lx", tpm_emu->caps);
>       ^
>
> On OSX:
> /Users/pm215/src/qemu-for-merges/hw/tpm/tpm_emulator.c:223:36: error:
> format specifies type 'unsigned long' but the argument has type
> 'ptm_cap' (aka 'unsigned long long') [-Werror,-Wformat]
>      DPRINTF("capbilities : 0x%lx", tpm_emu->caps);
>                               ~~~   ^~~~~~~~~~~~~
>                               %llx
> /Users/pm215/src/qemu-for-merges/hw/tpm/tpm_emulator.c:53:52: note:
> expanded from macro 'DPRINTF'
>          fprintf(stderr, "tpm-emulator:"fmt"\n", ## __VA_ARGS__); \
>                                                     ^
>
> thanks
> -- PMM