[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] checkpatch: replace ERROR with WARN for extern
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] checkpatch: replace ERROR with WARN for extern checking. |
Date: |
Wed, 11 Oct 2017 13:03:15 +0100 |
On 11 October 2017 at 05:33, Jiang Biao <address@hidden> wrote:
> There are some rare cases which need external declarations in .c
> files. patchew.org and checkpatch.pl will complain errors on
> patches for these declarations.
>
> Degrade ERROR to WARN to erase the error complaints taking
> checkpatch.pl in kernel as reference.
>
> Signed-off-by: Jiang Biao <address@hidden>
> ---
> scripts/checkpatch.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I'd rather not drop this to a warning for the sake of a single
use case that's already in the tree (and which if you really
cared about you could work around by putting the link_error()
declaration in a header file I suppose, though I wouldn't
bother personally.)
thanks
-- PMM