[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/5] basevm: Call logging.basicConfig()
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 2/5] basevm: Call logging.basicConfig() |
Date: |
Wed, 11 Oct 2017 15:51:00 -0300 |
Just setting level=DEBUG when debug is enabled is not enough: we
need to set up a log handler if we want debug messages generated
using logging.getLogger(...).debug() to be printed.
This was not a problem before because logging.debug() calls
logging.basicConfig() implicitly, but it's safer to not rely on
that.
Cc: "Alex Bennée" <address@hidden>
Cc: Fam Zheng <address@hidden>
Cc: "Philippe Mathieu-Daudé" <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Lukáš Doktor <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
tests/vm/basevm.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 3c863bc237..686d88decf 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -227,8 +227,8 @@ def main(vmcls):
if not argv and not args.build_qemu and not args.build_image:
print "Nothing to do?"
return 1
- if args.debug:
- logging.getLogger().setLevel(logging.DEBUG)
+ logging.basicConfig(level=(logging.DEBUG if args.debug
+ else logging.WARN))
vm = vmcls(debug=args.debug, vcpus=args.jobs)
if args.build_image:
if os.path.exists(args.image) and not args.force:
--
2.13.6
- [Qemu-devel] [PULL 0/5] Python queue, 2017-10-11, Eduardo Habkost, 2017/10/11
- [Qemu-devel] [PULL 1/5] iotests: Set up Python logging, Eduardo Habkost, 2017/10/11
- [Qemu-devel] [PULL 2/5] basevm: Call logging.basicConfig(),
Eduardo Habkost <=
- [Qemu-devel] [PULL 3/5] guestperf: Configure logging on all shell frontends, Eduardo Habkost, 2017/10/11
- [Qemu-devel] [PULL 4/5] scripts: Remove debug parameter from QEMUMonitorProtocol, Eduardo Habkost, 2017/10/11
- [Qemu-devel] [PULL 5/5] scripts: Remove debug parameter from QEMUMachine, Eduardo Habkost, 2017/10/11
- Re: [Qemu-devel] [PULL 0/5] Python queue, 2017-10-11, Peter Maydell, 2017/10/12