[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb-ccid: remove needless migration state code
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] usb-ccid: remove needless migration state code |
Date: |
Thu, 12 Oct 2017 15:29:15 +0200 |
On Thu, 2017-10-12 at 13:21 +0200, Marc-André Lureau wrote:
> This code appears to be unused since its introduction. It should be
> safe to remove from VMState.
Well, almost:
> @@ -1452,7 +1431,6 @@ static VMStateDescription ccid_vmstate = {
> VMSTATE_STRUCT_ARRAY(pending_answers, USBCCIDState,
> PENDING_ANSWERS_NUM, 1, answer_vmstate,
> Answer),
> VMSTATE_UINT32(pending_answers_num, USBCCIDState),
> - VMSTATE_UINT8(migration_state, USBCCIDState),
> VMSTATE_UINT32(state_vmstate, USBCCIDState),
> VMSTATE_END_OF_LIST()
> }
We have to keep this (or some placeholder) so the vmstate format
doesn't change.
cheers,
Gerd