[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] io: fix mem leak in websock error path
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2] io: fix mem leak in websock error path |
Date: |
Thu, 12 Oct 2017 08:53:15 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/12/2017 08:25 AM, Daniel P. Berrange wrote:
> Coverity pointed out the 'date' is not free()d in the error
> path
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> io/channel-websock.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/io/channel-websock.c b/io/channel-websock.c
> index aa35ef3274..df2c3a9f99 100644
> --- a/io/channel-websock.c
> +++ b/io/channel-websock.c
> @@ -341,7 +341,7 @@ static void
> qio_channel_websock_handshake_send_res_ok(QIOChannelWebsock *ioc,
> char combined_key[QIO_CHANNEL_WEBSOCK_CLIENT_KEY_LEN +
> QIO_CHANNEL_WEBSOCK_GUID_LEN + 1];
> char *accept = NULL;
> - char *date = qio_channel_websock_date_str();
> + char *date = NULL;
>
> g_strlcpy(combined_key, key, QIO_CHANNEL_WEBSOCK_CLIENT_KEY_LEN + 1);
> g_strlcat(combined_key, QIO_CHANNEL_WEBSOCK_GUID,
> @@ -360,6 +360,7 @@ static void
> qio_channel_websock_handshake_send_res_ok(QIOChannelWebsock *ioc,
> return;
> }
>
> + date = qio_channel_websock_date_str();
> qio_channel_websock_handshake_send_res(
> ioc, QIO_CHANNEL_WEBSOCK_HANDSHAKE_RES_OK, date, accept);
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature