[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg: Initialize cpu_env generically
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] tcg: Initialize cpu_env generically |
|
Date: |
Thu, 12 Oct 2017 07:45:30 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/11/2017 11:43 PM, Lluís Vilanova wrote:
>> /* Track which vCPU triggers events */
>> CPUState *cpu; /* *_trans */
>> - TCGv_env tcg_env; /* *_exec */
>
> I would rather keep it here instead of making a new global variable, since
> that
> should make it easier in the future to have multiple translation contexts.
Why do you believe this prevents it? The variable is literally identical for
*all* targets.
r~
PS: Everyone, please trim context that you don't care about. If you just add
two lines in the middle of 1000, I'll not always find it.