Re: [Qemu-devel] [PATCHv2 00/13] sun4m: sparc32_dma tidy-ups

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCHv2 00/13] sun4m: sparc32_dma tidy-ups

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
750844c42d sparc32_dma: add len to esp/le DMA memory tracing
ba7ab63f8e sparc32_dma: remove is_ledma hack and replace with memory region 
alias
cf74bfb2aa sparc32_dma: introduce new SPARC32_DMA type container object
1a9feba778 sparc32_dma: make lance device child of ledma device
86b3305848 lance: move TYPE_LANCE and SysBusPCNetState from lance.c to sun4m.h
c5ae1c6011 sparc32_dma: make esp device child of espdma device
420993a6ce esp: move TYPE_ESP and SysBusESPState from esp.c to esp.h
236dbd4516 sparc32_dma: use object link instead of qdev property to pass IOMMU 
reference
5165f5669a sun4m_iommu: move TYPE_SUN4M_IOMMU declaration to sun4m.h
850a150983 sun4m: move DMA device wiring from sparc32_dma_init() to 
sun4m_hw_init()
4ba0c4c9f1 sparc32_dma: move type declarations from sparc32_dma.c to 
sparc32_dma.h
553bbcee17 sparc32_dma: split esp and le into separate DMA devices
dd74a83295 sparc32_dma: rename SPARC32_DMA type to SPARC32_DMA_DEVICE

=== OUTPUT BEGIN ===
Checking PATCH 1/13: sparc32_dma: rename SPARC32_DMA type to 
SPARC32_DMA_DEVICE...
Checking PATCH 2/13: sparc32_dma: split esp and le into separate DMA devices...
Checking PATCH 3/13: sparc32_dma: move type declarations from sparc32_dma.c to 
sparc32_dma.h...
Checking PATCH 4/13: sun4m: move DMA device wiring from sparc32_dma_init() to 
sun4m_hw_init()...
ERROR: spaces required around that '*' (ctx:WxV)
#51: FILE: hw/sparc/sun4m.c:824:
+    qemu_irq *cpu_irqs[MAX_CPUS], slavio_irq[32], slavio_cpu_irq[MAX_CPUS];
              ^

total: 1 errors, 0 warnings, 66 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/13: sun4m_iommu: move TYPE_SUN4M_IOMMU declaration to 
sun4m.h...
Checking PATCH 6/13: sparc32_dma: use object link instead of qdev property to 
pass IOMMU reference...
Checking PATCH 7/13: esp: move TYPE_ESP and SysBusESPState from esp.c to 
esp.h...
Checking PATCH 8/13: sparc32_dma: make esp device child of espdma device...
Checking PATCH 9/13: lance: move TYPE_LANCE and SysBusPCNetState from lance.c 
to sun4m.h...
Checking PATCH 10/13: sparc32_dma: make lance device child of ledma device...
Checking PATCH 11/13: sparc32_dma: introduce new SPARC32_DMA type container 
object...
Checking PATCH 12/13: sparc32_dma: remove is_ledma hack and replace with memory 
region alias...
Checking PATCH 13/13: sparc32_dma: add len to esp/le DMA memory tracing...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden