Re: [Qemu-devel] [PATCH v3 00/32] Migration: postcopy failure recovery

[Peter Xu]

On Mon, Oct 16, 2017 at 01:05:04AM -0700, address@hidden wrote:
> Hi,
> 
> This series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce 
> it
> locally.
> 
> Type: series
> Message-id: address@hidden
> Subject: [Qemu-devel] [PATCH v3 00/32] Migration: postcopy failure recovery
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> set -e
> git submodule update --init dtc
> # Let docker tests dump environment info
> export SHOW_ENV=1
> export J=8
> time make address@hidden
> time make address@hidden
> time make address@hidden
> time make address@hidden
> === TEST SCRIPT END ===

[...]

>   GEN     trace/generated-helpers.c
>   CC      aarch64-softmmu/trace/control-target.o
>   CC      aarch64-softmmu/gdbstub-xml.o
>   CC      aarch64-softmmu/trace/generated-helpers.o
>   LINK    aarch64-softmmu/qemu-system-aarch64.exe
> ../migration/savevm.o: In function `postcopy_pause_incoming':
> /tmp/qemu-test/src/migration/savevm.c:2174: undefined reference to 
> `postcopy_fault_thread_notify'

I'm moving postcopy_fault_thread_notify() after the #endif of:

#if defined(__linux__) && defined(__NR_userfaultfd) && defined(CONFIG_EVENTFD)

Then problem solved.

Will hold before reposting until I got more comments.  Thanks,

-- 
Peter Xu