[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] kvm: tolerate non-existing slot for log_star
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v1] kvm: tolerate non-existing slot for log_start and log_stop |
Date: |
Mon, 16 Oct 2017 14:13:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 16/10/2017 11:41, David Hildenbrand wrote:
> log_start might be called by memory.c just before registering the
> section. So we can actually get a log_start without a region_add, which
> we can silently ignore.
This is really a bug in memory.c, I think. When you put together
everything as a single patch series, can you include the memory.c change
instead, and drop this reference in the commit message and the kvm-all.c
comment?
Thanks,
Paolo
> This makes current KVM code trigger an assertion
> ("kvm_section_update_flags: error finding slot").
>
> Also, if we want to trap every access to a section, we might not have a
> slot. So let's just tolerate if we don't have a slot.