[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v1 5/7] kvm: region_add and region_del is not called
From: |
David Hildenbrand |
Subject: |
[Qemu-devel] [PATCH v1 5/7] kvm: region_add and region_del is not called on updates |
Date: |
Mon, 16 Oct 2017 16:43:00 +0200 |
Attributes are not updated via region_add()/region_del(). Attribute changes
lead to a delete first, followed by a new add.
If this would ever not be the case, we would get an error when trying to
register the new slot.
Signed-off-by: David Hildenbrand <address@hidden>
---
accel/kvm/kvm-all.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 559c544501..2835bb3801 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -721,8 +721,8 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml,
ram = memory_region_get_ram_ptr(mr) + section->offset_within_region +
(start_addr - section->offset_within_address_space);
- mem = kvm_lookup_matching_slot(kml, start_addr, size);
if (!add) {
+ mem = kvm_lookup_matching_slot(kml, start_addr, size);
if (!mem) {
return;
}
@@ -741,12 +741,6 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml,
return;
}
- if (mem) {
- /* update the slot */
- kvm_slot_update_flags(kml, mem, mr);
- return;
- }
-
/* register the new slot */
mem = kvm_alloc_slot(kml);
mem->memory_size = size;
--
2.13.5
- [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups), David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 2/7] kvm: fix alignment of ram address, David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 3/7] kvm: tolerate non-existing slot for log_start/log_stop/log_sync, David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 1/7] memory: call log_start after region_add, David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 4/7] kvm: fix error message when failing to unregister slot, David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 5/7] kvm: region_add and region_del is not called on updates,
David Hildenbrand <=
- [Qemu-devel] [PATCH v1 6/7] kvm: simplify kvm_align_section(), David Hildenbrand, 2017/10/16
- [Qemu-devel] [PATCH v1 7/7] memory: reuse section_from_flat_range(), David Hildenbrand, 2017/10/16
- Re: [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups), Paolo Bonzini, 2017/10/16