[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 39/39] hw/dma/i8257: rename DMA_init() to i82
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 39/39] hw/dma/i8257: rename DMA_init() to i8257_dma_init() |
Date: |
Tue, 17 Oct 2017 08:47:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 17.10.2017 02:12, Philippe Mathieu-Daudé wrote:
> - move the header from hw/isa/ to hw/dma/
> - remove the old i386/pc dependency
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/hw/{isa/i8257.h => dma/i8257_dma.h} | 6 ++++++
> include/hw/isa/isa.h | 2 --
> hw/dma/i82374.c | 3 ++-
> hw/dma/i8257.c | 4 ++--
> hw/i386/pc.c | 3 ++-
> hw/mips/mips_fulong2e.c | 3 ++-
> hw/mips/mips_jazz.c | 3 ++-
> hw/mips/mips_malta.c | 3 ++-
> hw/sparc/sun4m.c | 4 ----
> hw/sparc64/sun4u.c | 4 ----
> 10 files changed, 18 insertions(+), 17 deletions(-)
> rename include/hw/{isa/i8257.h => dma/i8257_dma.h} (86%)
>
> diff --git a/include/hw/isa/i8257.h b/include/hw/dma/i8257_dma.h
> similarity index 86%
> rename from include/hw/isa/i8257.h
> rename to include/hw/dma/i8257_dma.h
I think you could drop the "_dma" suffix from the name - it is already
in a folder called "dma", so the context of this file should be clear
already.
Thomas
- [Qemu-devel] [PATCH v2 36/39] i386/pc: move pvpanic.c from hw/misc/ to hw/i386/, (continued)
- [Qemu-devel] [PATCH v2 36/39] i386/pc: move pvpanic.c from hw/misc/ to hw/i386/, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-devel] [PATCH v2 37/39] i386/pc: extract port92 from pc.c, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-devel] [PATCH v2 38/39] hw/dma/i82374: avoid multiple creations on the same ISA bus, Philippe Mathieu-Daudé, 2017/10/16
- [Qemu-devel] [PATCH v2 39/39] hw/dma/i8257: rename DMA_init() to i8257_dma_init(), Philippe Mathieu-Daudé, 2017/10/16
- Re: [Qemu-devel] [PATCH v2 39/39] hw/dma/i8257: rename DMA_init() to i8257_dma_init(),
Thomas Huth <=
- Re: [Qemu-devel] [PATCH v2 00/39] remove i386/pc dependency from non-PC world (part 1), no-reply, 2017/10/17