Re: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
781761ed55 windbg: implemented kd_api_query_memory
51254e498e windbg: implemented kd_api_fill_memory
66690a99b1 windbg: implemented kd_api_search_memory
2f6279f724 windbg: implemented kd_api_read_msr and kd_api_write_msr
ecbb8a4d90 windbg: implemented kd_api_get_version
99404b50d6 windbg: implemented kd_api_read_physical_memory and 
kd_api_write_physical_memory
ece9ee6e85 windbg: implemented kd_api_read_io_space and kd_api_write_io_space
8dee08947b windbg: implemented kd_api_continue
319a1cfd9a windbg: debug exception subscribing
0aae01739e windbg: implemented kd_api_write_breakpoint and 
kd_api_restore_breakpoint
87f6155ccc windbg: implemented windbg_hw_breakpoint_insert and 
windbg_hw_breakpoint_remove
6039691b57 windbg: implemented windbg_set_dr7
d6d36a9992 windbg: implemented windbg_set_dr
fa3991dc0d windbg: implemented windbg_set_sr
583ea26628 windbg: implemented windbg_write_ks_regs
fdf270f966 windbg: implemented windbg_read_ks_regs
05da1b9c5c windbg: implemented windbg_write_context
69df19d8e9 windbg: implemented windbg_read_context
d75b301976 windbg: implemented kd_api_read_control_space and 
kd_api_write_control_space
128fdb1ee0 windbg: implemented kd_api_get_context and kd_api_set_context
982f109a8f windbg: kernel's structures
cc264031d7 windbg: implemented kd_api_read_virtual_memory and 
kd_api_write_virtual_memory
825443663c windbg: implemented windbg_process_manipulate_packet
3891584ec0 windbg: implemented windbg_process_data_packet
d9b0dc02f9 windbg: implemented windbg_process_control_packet
7c4948139d windbg: windbg_vm_stop
c2b182a5cc windbg: generate LoadSymbolsStateChange
e1e0fa6049 windbg: generate ExceptionStateChange
1b46d89bec windbg: sized data buffer
1e2b1312bd windbg: init DBGKD_ANY_WAIT_STATE_CHANGE
c539c2eb16 windbg: handler of parsing context
aa620f7c0f windbg: send data and control packets
ec009bb58b windbg: parsing data stream
d92166ff9c windbg: structures for parsing data stream
c5af1bfa0a windbg: handler of fs/gs register
b2913d721d windbg: hook to wrmsr operation
ea4c4d5b07 windbg: added chardev
e3dcaa4bda windbg: added WindbgState
3b4e42af9d windbg: added helper features
5193519197 windbg: added '-windbg' option
ff48de606d windbg: modified windbgkd.h
034025ddba windbg: added windbg's KD header file
0645652f63 windbg: added empty windbgstub files

=== OUTPUT BEGIN ===
Checking PATCH 1/43: windbg: added empty windbgstub files...
ERROR: do not set execute permissions for source files
#28: FILE: include/exec/windbgstub-utils.h

ERROR: do not set execute permissions for source files
#52: FILE: include/exec/windbgstub.h

ERROR: do not set execute permissions for source files
#87: FILE: stubs/windbgstub.c

ERROR: do not set execute permissions for source files
#121: FILE: target/i386/windbgstub.c

ERROR: do not set execute permissions for source files
#140: FILE: windbgstub-utils.c

ERROR: do not set execute permissions for source files
#158: FILE: windbgstub.c

total: 6 errors, 0 warnings, 120 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/43: windbg: added windbg's KD header file...
ERROR: do not set execute permissions for source files
#14: FILE: include/exec/windbgkd.h

total: 1 errors, 0 warnings, 879 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/43: windbg: modified windbgkd.h...
Checking PATCH 4/43: windbg: added '-windbg' option...
Checking PATCH 5/43: windbg: added helper features...
Checking PATCH 6/43: windbg: added WindbgState...
Checking PATCH 7/43: windbg: added chardev...
Checking PATCH 8/43: windbg: hook to wrmsr operation...
Checking PATCH 9/43: windbg: handler of fs/gs register...
Checking PATCH 10/43: windbg: structures for parsing data stream...
Checking PATCH 11/43: windbg: parsing data stream...
Checking PATCH 12/43: windbg: send data and control packets...
Checking PATCH 13/43: windbg: handler of parsing context...
Checking PATCH 14/43: windbg: init DBGKD_ANY_WAIT_STATE_CHANGE...
Checking PATCH 15/43: windbg: sized data buffer...
Checking PATCH 16/43: windbg: generate ExceptionStateChange...
Checking PATCH 17/43: windbg: generate LoadSymbolsStateChange...
Checking PATCH 18/43: windbg: windbg_vm_stop...
Checking PATCH 19/43: windbg: implemented windbg_process_control_packet...
Checking PATCH 20/43: windbg: implemented windbg_process_data_packet...
Checking PATCH 21/43: windbg: implemented windbg_process_manipulate_packet...
Checking PATCH 22/43: windbg: implemented kd_api_read_virtual_memory and 
kd_api_write_virtual_memory...
Checking PATCH 23/43: windbg: kernel's structures...
Checking PATCH 24/43: windbg: implemented kd_api_get_context and 
kd_api_set_context...
Checking PATCH 25/43: windbg: implemented kd_api_read_control_space and 
kd_api_write_control_space...
Checking PATCH 26/43: windbg: implemented windbg_read_context...
Checking PATCH 27/43: windbg: implemented windbg_write_context...
Checking PATCH 28/43: windbg: implemented windbg_read_ks_regs...
Checking PATCH 29/43: windbg: implemented windbg_write_ks_regs...
Checking PATCH 30/43: windbg: implemented windbg_set_sr...
Checking PATCH 31/43: windbg: implemented windbg_set_dr...
Checking PATCH 32/43: windbg: implemented windbg_set_dr7...
Checking PATCH 33/43: windbg: implemented windbg_hw_breakpoint_insert and 
windbg_hw_breakpoint_remove...
Checking PATCH 34/43: windbg: implemented kd_api_write_breakpoint and 
kd_api_restore_breakpoint...
Checking PATCH 35/43: windbg: debug exception subscribing...
Checking PATCH 36/43: windbg: implemented kd_api_continue...
Checking PATCH 37/43: windbg: implemented kd_api_read_io_space and 
kd_api_write_io_space...
Checking PATCH 38/43: windbg: implemented kd_api_read_physical_memory and 
kd_api_write_physical_memory...
Checking PATCH 39/43: windbg: implemented kd_api_get_version...
Checking PATCH 40/43: windbg: implemented kd_api_read_msr and 
kd_api_write_msr...
Checking PATCH 41/43: windbg: implemented kd_api_search_memory...
Checking PATCH 42/43: windbg: implemented kd_api_fill_memory...
Checking PATCH 43/43: windbg: implemented kd_api_query_memory...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden