qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 02/50] tcg: Propagate args to op->args in opt


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v6 02/50] tcg: Propagate args to op->args in optimizer
Date: Tue, 17 Oct 2017 13:33:13 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 10/17/2017 01:28 PM, Emilio G. Cota wrote:
>> -        TCGArg * const args = op->args;
> 
> Reviewed-by: Emilio G. Cota <address@hidden>
> 
> Just for my own education: why doesn't gcc generate the same code when
> leaving 'args' as above? I thought we could simplify the diff without
> any side effects, but it turns out that more code is generated.

Um... this patch was intended to be code cleanup only.  It should have
generated the same code.  I admit I didn't check.

That there is a code difference is surprising and probably reportable as a
compiler bug.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]