[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 06/36] docker: Enable features explicitly in test
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PULL 06/36] docker: Enable features explicitly in test-full |
|
Date: |
Wed, 18 Oct 2017 16:09:47 +0800 |
|
User-agent: |
Mutt/1.9.0 (2017-09-02) |
On Mon, 10/02 16:21, Paolo Bonzini wrote:
> On 22/09/2017 09:46, Fam Zheng wrote:
> > Also avoid "set -e".
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > Message-Id: <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>
Sorry for late reply, I've had a backlog due to holiday and KVM Forum.
>
> This broke docker-test-full with at least Fedora and CentOS 6 images. I
> wouldn't be surprised if some required packages do not even exist on
> CentOS 6. Should it be reverted?
Packages not existing on CentOS 6 are supposed to be handled by "FEATURES" in
dockerfile and "requires" in test, but I suspect in this case the method scales,
the list will be cluttered and unmaintainable.
I'll send a reverting patch and continue hoping ./configure to detect features
automatically as before.
Fam