[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 00/10] Make xbzrle_cache_size a migration paramet
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH v2 00/10] Make xbzrle_cache_size a migration parameter |
Date: |
Wed, 18 Oct 2017 12:36:23 +0200 |
In v2
- rebase
- fix comments about power of 2 instead of multiple of two
- minor typo on error message
- use Error * when setting values
After asking people of libvirt/ovirt/openstack, it appears that there
is no problem about restricting cache_size to real values. We give
back one error and they had to handle errors already.
Please review, Juan.
[v1]
I started looking at xbzrle_cache_size and saw that it was not a parameter.
How difficult could it be? HaHa
- x-multifd-page-count and x-multifd-channels were not o
migrate_test_apply
- page_cache.c has parameters that were not used (max_item_age)
- page cache types were random. Move almost all to int/size_t as
appropiate
- error handling was split in three functions:
xbzrle_cache_resize
cache_init
qmp_set_cache_size
Make some sense of it and use Error*
- We pass one value to qmp_migrate_cache_size it asigned pow2log() of
that value, and cache_init() used a power of two. Make sure that
the value passed is right.
- Now I am able to make xbzrle_cache_size a parameter!!!!
- Now that I have arrived here, I tried to make the json types for
migartion parameters the real ones instead of everything is an int64.
I will be happy if libvirt people checked this.
Please review, Juan.
*** BLURB HERE ***
Juan Quintela (10):
migration: Fix migrate_test_apply for multifd parameters
migratiom: Remove max_item_age parameter
migration: Make cache size elements use the right types
migration: Move xbzrle cache resize error handling to
xbzrle_cache_resize
migration: Make cache_init() take an error parameter
migration: Make sure that we pass the right cache size
migration: Don't play games with the requested cache size
migration: No need to return the size of the cache
migration: Make xbzrle_cache_size a migration parameter
migration: [RFC] Use proper types in json
hmp.c | 34 ++++++++++-----
migration/migration.c | 116 ++++++++++++++++++++++++-------------------------
migration/migration.h | 1 -
migration/page_cache.c | 41 +++++++++--------
migration/page_cache.h | 7 ++-
migration/ram.c | 36 +++++++--------
migration/ram.h | 2 +-
qapi/migration.json | 44 ++++++++++++++-----
8 files changed, 160 insertions(+), 121 deletions(-)
--
2.13.6
- [Qemu-devel] [PATCH v2 00/10] Make xbzrle_cache_size a migration parameter,
Juan Quintela <=
- [Qemu-devel] [PATCH v2 01/10] migration: Fix migrate_test_apply for multifd parameters, Juan Quintela, 2017/10/18
- [Qemu-devel] [PATCH v2 03/10] migration: Make cache size elements use the right types, Juan Quintela, 2017/10/18
- [Qemu-devel] [PATCH v2 02/10] migratiom: Remove max_item_age parameter, Juan Quintela, 2017/10/18
- [Qemu-devel] [PATCH v2 04/10] migration: Move xbzrle cache resize error handling to xbzrle_cache_resize, Juan Quintela, 2017/10/18
- [Qemu-devel] [PATCH v2 06/10] migration: Make sure that we pass the right cache size, Juan Quintela, 2017/10/18
- [Qemu-devel] [PATCH v2 05/10] migration: Make cache_init() take an error parameter, Juan Quintela, 2017/10/18
- [Qemu-devel] [PATCH v2 07/10] migration: Don't play games with the requested cache size, Juan Quintela, 2017/10/18
- [Qemu-devel] [PATCH v2 08/10] migration: No need to return the size of the cache, Juan Quintela, 2017/10/18