[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 9/9] disas: Add capstone as submodule
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 9/9] disas: Add capstone as submodule |
|
Date: |
Wed, 18 Oct 2017 06:26:56 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/17/2017 10:48 PM, Gerd Hoffmann wrote:
> Hi,
>
>> +if [ "$capstone_internal" = "yes" ]; then
>> + echo "config-host.h: subdir-capstone" >> $config_host_mak
>> +fi
>
> I think this isn't going to work correctly. In case both capstone and
> dtc are used we need a single line with the dependencies, i.e.
>
> config-host.h: subdir-dtc subdir-capstone
Why? Without a build rule, I thought separate dependency lines accumulated.
r~
- [Qemu-devel] [PATCH v5 0/9] Support the Capstone disassembler, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 1/9] target/i386: Convert to disas_set_info hook, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 2/9] target/ppc: Convert to disas_set_info hook, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 3/9] disas: Remove unused flags arguments, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 4/9] disas: Support the Capstone disassembler library, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 6/9] arm: Support Capstone in disas_set_info, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 5/9] i386: Support Capstone in disas_set_info, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 9/9] disas: Add capstone as submodule, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 7/9] ppc: Support Capstone in disas_set_info, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 8/9] disas: Remove monitor_disas_is_physical, Richard Henderson, 2017/10/17