[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 9/9] disas: Add capstone as submodule
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v5 9/9] disas: Add capstone as submodule |
Date: |
Wed, 18 Oct 2017 14:34:28 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Oct 17, 2017 at 08:37:42AM -0700, Richard Henderson wrote:
> Do not require the submodule, but use it if present (in preference
> even to a system copy). This will allow us to easily use capstone
> in older systems for which a package is not available, and also
> easily track bug fixes from upstream.
I don't like the idea that we should blindly use the submodule
even if the host OS has it installed. This means developers working
on git will never be testing against the capstone that will actually
be used when they deploy a release build on their distro.
It also gives inconsistent behaviour wrt the way the dtc module
is handled, where we always try to use the system version and
only try the submodule if the system version is missing.
Thus I think we really ought to deal with capstone in the same
way as dtc. We could make the check a little more advanced so that
it checks for the particular capstone feature QEMU wants. That way
if someone does have an outdated capstone we'd still use the submodule.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v5 1/9] target/i386: Convert to disas_set_info hook, (continued)
- [Qemu-devel] [PATCH v5 1/9] target/i386: Convert to disas_set_info hook, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 2/9] target/ppc: Convert to disas_set_info hook, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 3/9] disas: Remove unused flags arguments, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 4/9] disas: Support the Capstone disassembler library, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 6/9] arm: Support Capstone in disas_set_info, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 5/9] i386: Support Capstone in disas_set_info, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 9/9] disas: Add capstone as submodule, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 7/9] ppc: Support Capstone in disas_set_info, Richard Henderson, 2017/10/17
- [Qemu-devel] [PATCH v5 8/9] disas: Remove monitor_disas_is_physical, Richard Henderson, 2017/10/17