Re: [Qemu-devel] [PATCH v3] NUMA: Enable adding NUMA node implicitly

[Dou Liyang]

Hi Igor,

> > diff --git a/vl.c b/vl.c
> > index 9bb5058..d083b4d 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -4665,7 +4665,11 @@ int main(int argc, char **argv, char **envp)
> >      default_drive(default_floppy, snapshot, IF_FLOPPY, 0, FD_OPTS);
> >      default_drive(default_sdcard, snapshot, IF_SD, 0, SD_OPTS);
> >
> > -    parse_numa_opts(current_machine);
> > +    current_machine->ram_size = ram_size;
> > +    current_machine->maxram_size = maxram_size;
> > +    current_machine->ram_slots = ram_slots;
> > +
> > +    parse_numa_opts(current_machine, ram_slots);
> >
> >      if (qemu_opts_foreach(qemu_find_opts("mon"),
> >                            mon_init_func, NULL, NULL)) {
> > @@ -4710,9 +4714,6 @@ int main(int argc, char **argv, char **envp)
> >      replay_checkpoint(CHECKPOINT_INIT);
> >      qdev_machine_init();
> >
> > -    current_machine->ram_size = ram_size;
> > -    current_machine->maxram_size = maxram_size;
> > -    current_machine->ram_slots = ram_slots;
> >      current_machine->boot_order = boot_order;
> >      current_machine->cpu_model = cpu_model;
> it should be safe to move parse_numa_opts(current_machine) here

Yes, Indeed!

I have modified and tested this, It's good. will change in the next
version.

Thanks,
        dou.

>