Re: [Qemu-devel] [PATCH v6 20/50] qom: Introduce CPUClass.tcg_initialize

[Philippe Mathieu-Daudé]

On 10/16/2017 02:25 PM, Richard Henderson wrote:
> Move target cpu tcg initialization to common code,
> called from cpu_exec_realizefn.
> 
> Cc: Andreas Färber <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>

much cleaner, esp. the CRIS part.
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  include/qom/cpu.h           |  8 ++++++--
>  target/sparc/cpu.h          |  2 +-
>  exec.c                      |  7 ++++++-
>  target/alpha/cpu.c          |  5 +----
>  target/alpha/translate.c    |  6 ------
>  target/arm/cpu.c            |  6 +-----
>  target/cris/cpu.c           | 16 ++++++----------
>  target/hppa/cpu.c           |  3 +--
>  target/hppa/translate.c     |  6 ------
>  target/i386/cpu.c           |  5 +----
>  target/i386/translate.c     |  6 ------
>  target/lm32/cpu.c           |  7 +------
>  target/m68k/cpu.c           |  7 +------
>  target/microblaze/cpu.c     |  7 +------
>  target/mips/cpu.c           |  5 +----
>  target/mips/translate.c     |  7 -------
>  target/moxie/cpu.c          |  7 +------
>  target/moxie/translate.c    |  6 ------
>  target/nios2/cpu.c          |  7 +------
>  target/openrisc/cpu.c       |  7 +------
>  target/ppc/translate.c      |  6 ------
>  target/ppc/translate_init.c |  5 +----
>  target/s390x/cpu.c          |  7 +------
>  target/sh4/cpu.c            |  5 +----
>  target/sh4/translate.c      |  7 -------
>  target/sparc/cpu.c          |  5 +----
>  target/sparc/translate.c    |  9 +--------
>  target/tilegx/cpu.c         |  7 +------
>  target/tricore/cpu.c        |  5 +----
>  target/tricore/translate.c  |  5 +----
>  target/unicore32/cpu.c      |  7 +------
>  target/xtensa/cpu.c         |  7 +------
>  32 files changed, 40 insertions(+), 165 deletions(-)