[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH a
From: |
Dong Jia Shi |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH |
Date: |
Thu, 19 Oct 2017 14:06:07 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Halil Pasic <address@hidden> [2017-10-17 16:04:49 +0200]:
> Simplify the error handling of the SSCH and RSCH handler avoiding
> arbitrary and cryptic error codes being used to tell how the instruction
> is supposed to end. Let the code detecting the condition tell how it's
> to be handled in a less ambiguous way. It's best to handle SSCH and RSCH
> in one go as the emulation of the two shares a lot of code.
>
> For passthrough this change isn't pure refactoring, but changes the way
> kernel reported EFAULT is handled. After clarifying the kernel interface
> we decided that EFAULT shall be mapped to unit exception. Same goes for
> unexpected error codes and absence of required ORB flags.
>
> Signed-off-by: Halil Pasic <address@hidden>
> ---
> hw/s390x/css.c | 84
> +++++++++++++--------------------------------
> hw/s390x/s390-ccw.c | 11 +++---
> hw/vfio/ccw.c | 28 +++++++++++----
> include/hw/s390x/css.h | 23 +++++++++----
> include/hw/s390x/s390-ccw.h | 2 +-
> target/s390x/ioinst.c | 53 ++++------------------------
> 6 files changed, 75 insertions(+), 126 deletions(-)
>
Agree for what already planned to fix when applying.
LGTM:
Reviewed-by: Dong Jia Shi <address@hidden>
--
Dong Jia Shi
- Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH, (continued)
- Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH, Cornelia Huck, 2017/10/18
- Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH, Thomas Huth, 2017/10/18
- Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH, Halil Pasic, 2017/10/18
- Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH, Thomas Huth, 2017/10/18
- Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH, Halil Pasic, 2017/10/18
Re: [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH,
Dong Jia Shi <=
[Qemu-devel] [PATCH v3 2/7] s390x/css: IO instr handler ending control, Halil Pasic, 2017/10/17
[Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler, Halil Pasic, 2017/10/17