[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK6
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0 |
Date: |
Thu, 19 Oct 2017 12:29:05 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64
MK64FN1M0
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3ac7610368 arm: Adding new arm machine, Kinetis K64 MK64FN1M0
=== OUTPUT BEGIN ===
Checking PATCH 1/1: arm: Adding new arm machine, Kinetis K64 MK64FN1M0...
ERROR: do not set execute permissions for source files
#24: FILE: hw/arm/kinetis/k64/mk64fn1m0.c
ERROR: spaces required around that '*' (ctx:VxV)
#62: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:34:
+#define FLASH_SIZE 1024*1024
^
ERROR: Macros with complex values should be enclosed in parenthesis
#62: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:34:
+#define FLASH_SIZE 1024*1024
ERROR: spaces required around that '*' (ctx:VxV)
#64: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:36:
+#define SRAM_SIZE 192*1024
^
ERROR: Macros with complex values should be enclosed in parenthesis
#64: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:36:
+#define SRAM_SIZE 192*1024
ERROR: trailing whitespace
#97: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:69:
+ $
ERROR: trailing whitespace
#104: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:76:
+ $
ERROR: trailing whitespace
#122: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:94:
+ $
ERROR: do not use C99 // comments
#136: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:108:
+// sysbus_create_simple(TYPE_KINETIS_K64_UART, 0x4006A000,
ERROR: do not use C99 // comments
#137: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:109:
+// qdev_get_gpio_in(nvic, 31)); /*UART0*/
ERROR: trailing whitespace
#139: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:111:
+ serial_hds[0]); $
ERROR: trailing whitespace
#158: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:130:
+ $
ERROR: adding a line without newline at end of file
#198: FILE: hw/arm/kinetis/k64/mk64fn1m0.c:170:
+type_init(mk64fn1m0_machine_init)
ERROR: do not set execute permissions for source files
#201: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c
ERROR: trailing whitespace
#216: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:11:
+ $
ERROR: trailing whitespace
#233: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:28:
+#include "hw/arm/kinetis/k64/peripheral/flextimer.h" $
ERROR: do not use C99 // comments
#242: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:37:
+// VMSTATE_UINT32(CONTROLS[0], kinetis_k64_flextimer_state),
ERROR: trailing whitespace
#270: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:65:
+ $
ERROR: do not use C99 // comments
#277: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:72:
+// kinetis_k64_flextimer_state *s = (kinetis_k64_flextimer_state *)opaque;
ERROR: trailing whitespace
#278: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:73:
+^I$
ERROR: code indent should never use tabs
#278: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:73:
+^I$
ERROR: trailing whitespace
#282: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:77:
+ $
ERROR: switch and case should be at the same indent
#283: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:78:
+ switch (offset) {
+ default:
ERROR: do not use C99 // comments
#294: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:89:
+// kinetis_k64_flextimer_state *s = (kinetis_k64_flextimer_state *)opaque;
ERROR: switch and case should be at the same indent
#296: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:91:
+ switch (offset) {
+ default:
ERROR: trailing whitespace
#315: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:110:
+ $
ERROR: trailing whitespace
#328: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:123:
+ dc->desc = "Kinetis K64 series FlexTimer"; $
ERROR: adding a line without newline at end of file
#344: FILE: hw/arm/kinetis/k64/peripheral/flextimer.c:139:
+type_init(kinetis_k64_flextimer_register_types)
ERROR: do not set execute permissions for source files
#347: FILE: hw/arm/kinetis/k64/peripheral/mcg.c
ERROR: trailing whitespace
#362: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:11:
+ $
ERROR: trailing whitespace
#405: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:54:
+ $
ERROR: trailing whitespace
#426: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:75:
+/* printf("kinetis_k64_mcg_write: Offset = 0x%02X, Value = 0x%02X\n", $
ERROR: trailing whitespace
#427: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:76:
+ (unsigned int)offset, (unsigned int)value);*/ $
ERROR: trailing whitespace
#428: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:77:
+ $
ERROR: switch and case should be at the same indent
#429: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:78:
+ switch (offset) {
+ case 0x00: /**< MCG Control 1 Register, offset: 0x0 */
[...]
+ case 0x01: /**< MCG Control 2 Register, offset: 0x1 */
[...]
+ case 0x02: /**< MCG Control 3 Register, offset: 0x2 */
[...]
+ case 0x03: /**< MCG Control 4 Register, offset: 0x3 */
[...]
+ case 0x04: /**< MCG Control 5 Register, offset: 0x4 */
[...]
+ case 0x05: /**< MCG Control 6 Register, offset: 0x5 */
[...]
+ case 0x06: /**< MCG Status Register, offset: 0x6 */
[...]
+ case 0x08: /**< MCG Status and Control Register, offset: 0x8 */
[...]
+ case 0x0A: /**< MCG Auto Trim Compare Value High Register, offset:
0xA*/
[...]
+ case 0x0B: /**< MCG Auto Trim Compare Value Low Register, offset: 0xB
*/
[...]
+ case 0x0C: /**< MCG Control 7 Register, offset: 0xC */
[...]
+ case 0x0D: /**< MCG Control 8 Register, offset: 0xD */
[...]
+ default:
ERROR: do not use C99 // comments
#431: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:80:
+ if (value & 1<<2){ //IREFS
ERROR: spaces required around that '<<' (ctx:VxV)
#431: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:80:
+ if (value & 1<<2){ //IREFS
^
ERROR: space required before the open brace '{'
#431: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:80:
+ if (value & 1<<2){ //IREFS
ERROR: trailing statements should be on next line
#431: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:80:
+ if (value & 1<<2){ //IREFS
ERROR: trailing whitespace
#432: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:81:
+ s->S = 0; $
ERROR: trailing whitespace
#433: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:82:
+ s->S |= 1<<3; // 10 Enconding 2 - External ref clk is selected
$
WARNING: line over 80 characters
#433: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:82:
+ s->S |= 1<<3; // 10 Enconding 2 - External ref clk is selected
ERROR: do not use C99 // comments
#433: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:82:
+ s->S |= 1<<3; // 10 Enconding 2 - External ref clk is selected
ERROR: spaces required around that '<<' (ctx:VxV)
#433: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:82:
+ s->S |= 1<<3; // 10 Enconding 2 - External ref clk is selected
^
ERROR: spaces required around that '>>' (ctx:VxV)
#435: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:84:
+ if ((s->C1 & 0x80) && (value>>6 == 0)){
^
ERROR: space required before the open brace '{'
#435: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:84:
+ if ((s->C1 & 0x80) && (value>>6 == 0)){
ERROR: trailing whitespace
#436: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:85:
+ s->S |= 1<<2; // 11 Enconding 3 - Output of the PLL is
selected $
WARNING: line over 80 characters
#436: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:85:
+ s->S |= 1<<2; // 11 Enconding 3 - Output of the PLL is
selected
ERROR: do not use C99 // comments
#436: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:85:
+ s->S |= 1<<2; // 11 Enconding 3 - Output of the PLL is
selected
ERROR: spaces required around that '<<' (ctx:VxV)
#436: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:85:
+ s->S |= 1<<2; // 11 Enconding 3 - Output of the PLL is
selected
^
ERROR: do not use C99 // comments
#451: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:100:
+ if (s->C5 & 1<<6){ //PLLCLKEN0
ERROR: spaces required around that '<<' (ctx:VxV)
#451: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:100:
+ if (s->C5 & 1<<6){ //PLLCLKEN0
^
ERROR: space required before the open brace '{'
#451: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:100:
+ if (s->C5 & 1<<6){ //PLLCLKEN0
ERROR: trailing statements should be on next line
#451: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:100:
+ if (s->C5 & 1<<6){ //PLLCLKEN0
ERROR: trailing whitespace
#452: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:101:
+ s->S |= 1<<6; //LOCK0 $
ERROR: do not use C99 // comments
#452: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:101:
+ s->S |= 1<<6; //LOCK0
ERROR: spaces required around that '<<' (ctx:VxV)
#452: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:101:
+ s->S |= 1<<6; //LOCK0
^
ERROR: do not use C99 // comments
#457: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:106:
+ if (s->C6 & 1<<6){ //PLLS
ERROR: spaces required around that '<<' (ctx:VxV)
#457: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:106:
+ if (s->C6 & 1<<6){ //PLLS
^
ERROR: space required before the open brace '{'
#457: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:106:
+ if (s->C6 & 1<<6){ //PLLS
ERROR: trailing statements should be on next line
#457: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:106:
+ if (s->C6 & 1<<6){ //PLLS
ERROR: trailing whitespace
#458: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:107:
+ s->S |= 1<<5; //PLLST $
ERROR: do not use C99 // comments
#458: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:107:
+ s->S |= 1<<5; //PLLST
ERROR: spaces required around that '<<' (ctx:VxV)
#458: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:107:
+ s->S |= 1<<5; //PLLST
^
ERROR: trailing whitespace
#459: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:108:
+ } $
ERROR: trailing whitespace
#489: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:138:
+ $
ERROR: switch and case should be at the same indent
#490: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:139:
+ switch (offset) {
+ case 0x00: /**< MCG Control 1 Register, offset: 0x0 */
[...]
+ case 0x01: /**< MCG Control 2 Register, offset: 0x1 */
[...]
+ case 0x02: /**< MCG Control 3 Register, offset: 0x2 */
[...]
+ case 0x03: /**< MCG Control 4 Register, offset: 0x3 */
[...]
+ case 0x04: /**< MCG Control 5 Register, offset: 0x4 */
[...]
+ case 0x05: /**< MCG Control 6 Register, offset: 0x5 */
[...]
+ case 0x06: /**< MCG Status Register, offset: 0x6 */
[...]
+ case 0x08: /**< MCG Status and Control Register, offset: 0x8 */
[...]
+ case 0x0A: /**< MCG Auto Trim Compare Value High Register, offset:
0xA*/
[...]
+ case 0x0B: /**< MCG Auto Trim Compare Value Low Register, offset: 0xB
*/
[...]
+ case 0x0C: /**< MCG Control 7 Register, offset: 0xC */
[...]
+ case 0x0D: /**< MCG Control 8 Register, offset: 0xD */
[...]
+ default:
ERROR: trailing whitespace
#528: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:177:
+ qemu_log_mask(LOG_GUEST_ERROR, $
ERROR: trailing whitespace
#534: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:183:
+ return value; $
ERROR: trailing whitespace
#547: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:196:
+ $
ERROR: trailing whitespace
#560: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:209:
+ dc->desc = "Kinetis K64 series MCG"; $
ERROR: adding a line without newline at end of file
#576: FILE: hw/arm/kinetis/k64/peripheral/mcg.c:225:
+type_init(kinetis_k64_mcg_register_types)
ERROR: do not set execute permissions for source files
#579: FILE: hw/arm/kinetis/k64/peripheral/pmux.c
ERROR: trailing whitespace
#594: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:11:
+ $
ERROR: trailing whitespace
#596: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:13:
+ $
ERROR: trailing whitespace
#663: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:80:
+ $
ERROR: trailing whitespace
#664: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:81:
+ s->PCR00 = 0x00000000; $
ERROR: trailing whitespace
#665: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:82:
+ s->PCR01 = 0x00000000; $
ERROR: trailing whitespace
#666: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:83:
+ s->PCR02 = 0x00000000; $
ERROR: trailing whitespace
#667: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:84:
+ s->PCR03 = 0x00000000; $
ERROR: trailing whitespace
#668: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:85:
+ s->PCR04 = 0x00000000; $
ERROR: trailing whitespace
#669: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:86:
+ s->PCR05 = 0x00000000; $
ERROR: trailing whitespace
#670: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:87:
+ s->PCR06 = 0x00000000; $
ERROR: trailing whitespace
#671: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:88:
+ s->PCR07 = 0x00000000; $
ERROR: trailing whitespace
#672: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:89:
+ s->PCR08 = 0x00000000; $
ERROR: trailing whitespace
#673: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:90:
+ s->PCR09 = 0x00000000; $
ERROR: trailing whitespace
#674: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:91:
+ s->PCR10 = 0x00000000; $
ERROR: trailing whitespace
#675: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:92:
+ s->PCR11 = 0x00000000; $
ERROR: trailing whitespace
#676: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:93:
+ s->PCR12 = 0x00000000; $
ERROR: trailing whitespace
#677: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:94:
+ s->PCR13 = 0x00000000; $
ERROR: trailing whitespace
#678: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:95:
+ s->PCR14 = 0x00000000; $
ERROR: trailing whitespace
#679: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:96:
+ s->PCR15 = 0x00000000; $
ERROR: trailing whitespace
#680: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:97:
+ s->PCR16 = 0x00000000; $
ERROR: trailing whitespace
#681: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:98:
+ s->PCR17 = 0x00000000; $
ERROR: trailing whitespace
#682: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:99:
+ s->PCR18 = 0x00000000; $
ERROR: trailing whitespace
#683: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:100:
+ s->PCR19 = 0x00000000; $
ERROR: trailing whitespace
#684: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:101:
+ s->PCR20 = 0x00000000; $
ERROR: trailing whitespace
#685: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:102:
+ s->PCR21 = 0x00000000; $
ERROR: trailing whitespace
#686: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:103:
+ s->PCR22 = 0x00000000; $
ERROR: trailing whitespace
#687: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:104:
+ s->PCR23 = 0x00000000; $
ERROR: trailing whitespace
#688: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:105:
+ s->PCR24 = 0x00000000; $
ERROR: trailing whitespace
#689: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:106:
+ s->PCR25 = 0x00000000; $
ERROR: trailing whitespace
#690: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:107:
+ s->PCR26 = 0x00000000; $
ERROR: trailing whitespace
#691: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:108:
+ s->PCR27 = 0x00000000; $
ERROR: trailing whitespace
#692: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:109:
+ s->PCR28 = 0x00000000; $
ERROR: trailing whitespace
#693: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:110:
+ s->PCR29 = 0x00000000; $
ERROR: trailing whitespace
#694: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:111:
+ s->PCR30 = 0x00000000; $
ERROR: trailing whitespace
#695: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:112:
+ s->PCR31 = 0x00000000; $
ERROR: trailing whitespace
#696: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:113:
+ s->GPCLR = 0x00000000; $
ERROR: trailing whitespace
#697: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:114:
+ s->GPCHR = 0x00000000; $
ERROR: trailing whitespace
#698: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:115:
+ s->ISFR = 0x00000000; $
ERROR: trailing whitespace
#699: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:116:
+ s->DFER = 0x00000000; $
ERROR: trailing whitespace
#700: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:117:
+ s->DFCR = 0x00000000; $
ERROR: trailing whitespace
#712: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:129:
+ $
ERROR: switch and case should be at the same indent
#713: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:130:
+ switch (offset) {
+ case 0x00: /**< Pin Control Register n, offset: 0x0, step: 0x4 */
[...]
+ case 0x04:
[...]
+ case 0x08:
[...]
+ case 0x0C:
[...]
+ case 0x10:
[...]
+ case 0x14:
[...]
+ case 0x18:
[...]
+ case 0x1C:
[...]
+ case 0x20:
[...]
+ case 0x24:
[...]
+ case 0x28:
[...]
+ case 0x2C:
[...]
+ case 0x30:
[...]
+ case 0x34:
[...]
+ case 0x38:
[...]
+ case 0x3C:
[...]
+ case 0x40:
[...]
+ case 0x44:
[...]
+ case 0x48:
[...]
+ case 0x4C:
[...]
+ case 0x50:
[...]
+ case 0x54:
[...]
+ case 0x58:
[...]
+ case 0x5C:
[...]
+ case 0x60:
[...]
+ case 0x64:
[...]
+ case 0x68:
[...]
+ case 0x6C:
[...]
+ case 0x70:
[...]
+ case 0x74:
[...]
+ case 0x78:
[...]
+ case 0x7C:
[...]
+ case 0x80: /**< Global Pin Control Low Register, offset: 0x80 */
[...]
+ case 0x84: /**< Global Pin Control High Register, offset: 0x84 */
[...]
+ case 0xA0: /**< Interrupt Status Flag Register, offset: 0xA0 */
[...]
+ case 0xC0: /**< Digital Filter Enable Register, offset: 0xC0 */
[...]
+ case 0xC4: /**< Digital Filter Clock Register, offset: 0xC4 */
[...]
+ case 0xC8: /**< Digital Filter Width Register, offset: 0xC8 */
[...]
+ default:
ERROR: trailing whitespace
#717: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:134:
+ case 0x04: $
ERROR: trailing whitespace
#720: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:137:
+ case 0x08: $
ERROR: trailing whitespace
#723: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:140:
+ case 0x0C: $
ERROR: trailing whitespace
#726: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:143:
+ case 0x10: $
ERROR: trailing whitespace
#729: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:146:
+ case 0x14: $
ERROR: trailing whitespace
#732: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:149:
+ case 0x18: $
ERROR: trailing whitespace
#735: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:152:
+ case 0x1C: $
ERROR: trailing whitespace
#738: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:155:
+ case 0x20: $
ERROR: trailing whitespace
#741: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:158:
+ case 0x24: $
ERROR: trailing whitespace
#744: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:161:
+ case 0x28: $
ERROR: trailing whitespace
#747: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:164:
+ case 0x2C: $
ERROR: trailing whitespace
#750: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:167:
+ case 0x30: $
ERROR: trailing whitespace
#753: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:170:
+ case 0x34: $
ERROR: trailing whitespace
#756: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:173:
+ case 0x38: $
ERROR: trailing whitespace
#759: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:176:
+ case 0x3C: $
ERROR: trailing whitespace
#762: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:179:
+ case 0x40: $
ERROR: trailing whitespace
#765: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:182:
+ case 0x44: $
ERROR: trailing whitespace
#768: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:185:
+ case 0x48: $
ERROR: trailing whitespace
#828: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:245:
+ $
ERROR: trailing whitespace
#841: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:258:
+ $
ERROR: switch and case should be at the same indent
#842: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:259:
+ switch (offset) {
+ case 0x00: /**< Pin Control Register n, offset: 0x0, step: 0x4 */
[...]
+ case 0x04:
[...]
+ case 0x08:
[...]
+ case 0x0C:
[...]
+ case 0x10:
[...]
+ case 0x14:
[...]
+ case 0x18:
[...]
+ case 0x1C:
[...]
+ case 0x20:
[...]
+ case 0x24:
[...]
+ case 0x28:
[...]
+ case 0x2C:
[...]
+ case 0x30:
[...]
+ case 0x34:
[...]
+ case 0x38:
[...]
+ case 0x3C:
[...]
+ case 0x40:
[...]
+ case 0x44:
[...]
+ case 0x48:
[...]
+ case 0x4C:
[...]
+ case 0x50:
[...]
+ case 0x54:
[...]
+ case 0x58:
[...]
+ case 0x5C:
[...]
+ case 0x60:
[...]
+ case 0x64:
[...]
+ case 0x68:
[...]
+ case 0x6C:
[...]
+ case 0x70:
[...]
+ case 0x74:
[...]
+ case 0x78:
[...]
+ case 0x7C:
[...]
+ case 0x80: /**< Global Pin Control Low Register, offset: 0x80 */
[...]
+ case 0x84: /**< Global Pin Control High Register, offset: 0x84 */
[...]
+ case 0xA0: /**< Interrupt Status Flag Register, offset: 0xA0 */
[...]
+ case 0xC0: /**< Digital Filter Enable Register, offset: 0xC0 */
[...]
+ case 0xC4: /**< Digital Filter Clock Register, offset: 0xC4 */
[...]
+ case 0xC8: /**< Digital Filter Width Register, offset: 0xC8 */
[...]
+ default:
ERROR: trailing whitespace
#846: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:263:
+ case 0x04: $
ERROR: trailing whitespace
#849: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:266:
+ case 0x08: $
ERROR: trailing whitespace
#852: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:269:
+ case 0x0C: $
ERROR: trailing whitespace
#855: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:272:
+ case 0x10: $
ERROR: trailing whitespace
#858: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:275:
+ case 0x14: $
ERROR: trailing whitespace
#861: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:278:
+ case 0x18: $
ERROR: trailing whitespace
#864: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:281:
+ case 0x1C: $
ERROR: trailing whitespace
#867: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:284:
+ case 0x20: $
ERROR: trailing whitespace
#870: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:287:
+ case 0x24: $
ERROR: trailing whitespace
#873: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:290:
+ case 0x28: $
ERROR: trailing whitespace
#876: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:293:
+ case 0x2C: $
ERROR: trailing whitespace
#879: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:296:
+ case 0x30: $
ERROR: trailing whitespace
#882: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:299:
+ case 0x34: $
ERROR: trailing whitespace
#885: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:302:
+ case 0x38: $
ERROR: trailing whitespace
#888: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:305:
+ case 0x3C: $
ERROR: trailing whitespace
#891: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:308:
+ case 0x40: $
ERROR: trailing whitespace
#894: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:311:
+ case 0x44: $
ERROR: trailing whitespace
#897: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:314:
+ case 0x48: $
ERROR: trailing whitespace
#962: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:379:
+/* printf("kinetis_k64_pmux_read: Offset = 0x%08X, Value = 0x%08X\n", $
ERROR: trailing whitespace
#977: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:394:
+ $
ERROR: trailing whitespace
#990: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:407:
+ dc->desc = "Kinetis K64 series PMUX"; $
ERROR: adding a line without newline at end of file
#1006: FILE: hw/arm/kinetis/k64/peripheral/pmux.c:423:
+type_init(kinetis_k64_pmux_register_types)
ERROR: do not set execute permissions for source files
#1009: FILE: hw/arm/kinetis/k64/peripheral/sim.c
ERROR: trailing whitespace
#1024: FILE: hw/arm/kinetis/k64/peripheral/sim.c:11:
+ $
ERROR: trailing whitespace
#1026: FILE: hw/arm/kinetis/k64/peripheral/sim.c:13:
+ $
ERROR: trailing whitespace
#1077: FILE: hw/arm/kinetis/k64/peripheral/sim.c:64:
+ $
ERROR: trailing whitespace
#1110: FILE: hw/arm/kinetis/k64/peripheral/sim.c:97:
+ $
ERROR: switch and case should be at the same indent
#1111: FILE: hw/arm/kinetis/k64/peripheral/sim.c:98:
+ switch (offset) {
+ case 0x0000: /**< System Options Register 1, offset: 0x0 */
[...]
+ case 0x0004: /**< SOPT1 Configuration Register, offset: 0x4 */
[...]
+ case 0x1004: /**< System Options Register 2, offset: 0x1004 */
[...]
+ case 0x100C: /**< System Options Register 4, offset: 0x100C */
[...]
+ case 0x1010: /**< System Options Register 5, offset: 0x1010 */
[...]
+ case 0x1018: /**< System Options Register 7, offset: 0x1018 */
[...]
+ case 0x1024: /**< System Device Id Register, offset: 0x1024 */
[...]
+ case 0x1028: /**< System Clock Gating Ctrl Register 1, offset: 0x1028
*/
[...]
+ case 0x102C: /**< System Clock Gating Ctrl Register 2, offset: 0x102C
*/
[...]
+ case 0x1030: /**< System Clock Gating Ctrl Register 3, offset: 0x1030
*/
[...]
+ case 0x1034: /**< System Clock Gating Ctrl Register 4, offset: 0x1034
*/
[...]
+ case 0x1013: /**< System Clock Gating Ctrl Register 5, offset: 0x1038
*/
[...]
+ case 0x103C: /**< System Clock Gating Ctrl Register 6, offset: 0x103C
*/
[...]
+ case 0x1040: /**< System Clock Gating Ctrl Register 7, offset: 0x1040
*/
[...]
+ case 0x1044: /**< System Clock Divider Register 1, offset: 0x1044 */
[...]
+ case 0x1048: /**< System Clock Divider Register 2, offset: 0x1048 */
[...]
+ case 0x104C: /**< Flash Configuration Register 1, offset: 0x104C */
[...]
+ case 0x1050: /**< Flash Configuration Register 2, offset: 0x1050 */
[...]
+ case 0x1054: /**< Unique Id Register High, offset: 0x1054 */
[...]
+ case 0x1058: /**< Unique Id Register Mid-High, offset: 0x1058 */
[...]
+ case 0x105C: /**< Unique Id Register Mid Low, offset: 0x105C */
[...]
+ case 0x1060: /**< Unique Id Register Low, offset: 0x1060 */
[...]
+ default:
ERROR: trailing whitespace
#1175: FILE: hw/arm/kinetis/k64/peripheral/sim.c:162:
+ case 0x1060: /**< Unique Id Register Low, offset: 0x1060 */ $
ERROR: trailing whitespace
#1176: FILE: hw/arm/kinetis/k64/peripheral/sim.c:163:
+ s->UIDL = value; $
ERROR: trailing whitespace
#1189: FILE: hw/arm/kinetis/k64/peripheral/sim.c:176:
+ $
ERROR: switch and case should be at the same indent
#1190: FILE: hw/arm/kinetis/k64/peripheral/sim.c:177:
+ switch (offset) {
+ case 0x0000: /**< System Options Register 1, offset: 0x0 */
[...]
+ case 0x0004: /**< SOPT1 Configuration Register, offset: 0x4 */
[...]
+ case 0x1004: /**< System Options Register 2, offset: 0x1004 */
[...]
+ case 0x100C: /**< System Options Register 4, offset: 0x100C */
[...]
+ case 0x1010: /**< System Options Register 5, offset: 0x1010 */
[...]
+ case 0x1018: /**< System Options Register 7, offset: 0x1018 */
[...]
+ case 0x1024: /**< System Device Id Register, offset: 0x1024 */
[...]
+ case 0x1028: /**< System Clock Gating Ctrl Register 1, offset: 0x1028
*/
[...]
+ case 0x102C: /**< System Clock Gating Ctrl Register 2, offset: 0x102C
*/
[...]
+ case 0x1030: /**< System Clock Gating Ctrl Register 3, offset: 0x1030
*/
[...]
+ case 0x1034: /**< System Clock Gating Ctrl Register 4, offset: 0x1034
*/
[...]
+ case 0x1013: /**< System Clock Gating Ctrl Register 5, offset: 0x1038
*/
[...]
+ case 0x103C: /**< System Clock Gating Ctrl Register 6, offset: 0x103C
*/
[...]
+ case 0x1040: /**< System Clock Gating Ctrl Register 7, offset: 0x1040
*/
[...]
+ case 0x1044: /**< System Clock Divider Register 1, offset: 0x1044 */
[...]
+ case 0x1048: /**< System Clock Divider Register 2, offset: 0x1048 */
[...]
+ case 0x104C: /**< Flash Configuration Register 1, offset: 0x104C */
[...]
+ case 0x1050: /**< Flash Configuration Register 2, offset: 0x1050 */
[...]
+ case 0x1054: /**< Unique Id Register High, offset: 0x1054 */
[...]
+ case 0x1058: /**< Unique Id Register Mid-High, offset: 0x1058 */
[...]
+ case 0x105C: /**< Unique Id Register Mid Low, offset: 0x105C */
[...]
+ case 0x1060: /**< Unique Id Register Low, offset: 0x1060 */
[...]
+ default:
ERROR: trailing whitespace
#1254: FILE: hw/arm/kinetis/k64/peripheral/sim.c:241:
+ case 0x1060: /**< Unique Id Register Low, offset: 0x1060 */ $
ERROR: trailing whitespace
#1264: FILE: hw/arm/kinetis/k64/peripheral/sim.c:251:
+ return value; $
ERROR: trailing whitespace
#1277: FILE: hw/arm/kinetis/k64/peripheral/sim.c:264:
+ $
ERROR: adding a line without newline at end of file
#1305: FILE: hw/arm/kinetis/k64/peripheral/sim.c:292:
+type_init(kinetis_k64_sim_register_types)
ERROR: do not set execute permissions for source files
#1308: FILE: hw/arm/kinetis/k64/peripheral/uart.c
ERROR: trailing whitespace
#1323: FILE: hw/arm/kinetis/k64/peripheral/uart.c:11:
+ $
ERROR: trailing whitespace
#1376: FILE: hw/arm/kinetis/k64/peripheral/uart.c:64:
+ VMSTATE_UINT8(TL7816, kinetis_k64_uart_state), $
ERROR: trailing whitespace
#1384: FILE: hw/arm/kinetis/k64/peripheral/uart.c:72:
+ $
ERROR: trailing whitespace
#1415: FILE: hw/arm/kinetis/k64/peripheral/uart.c:103:
+ $
ERROR: trailing whitespace
#1426: FILE: hw/arm/kinetis/k64/peripheral/uart.c:114:
+ (unsigned int)offset, (unsigned int)value, (unsigned int)value);*/
$
WARNING: line over 80 characters
#1426: FILE: hw/arm/kinetis/k64/peripheral/uart.c:114:
+ (unsigned int)offset, (unsigned int)value, (unsigned int)value);*/
ERROR: trailing whitespace
#1427: FILE: hw/arm/kinetis/k64/peripheral/uart.c:115:
+ $
ERROR: switch and case should be at the same indent
#1428: FILE: hw/arm/kinetis/k64/peripheral/uart.c:116:
+ switch (offset) {
+ case 0x00: /**< UART Baud Rate Registers: High, offset: 0x0 */
[...]
+ case 0x01: /**< UART Baud Rate Registers: Low, offset: 0x1 */
[...]
+ case 0x02: /**< UART Control Register 1, offset: 0x2 */
[...]
+ case 0x03: /**< UART Control Register 2, offset: 0x3 */
[...]
+ case 0x04: /**< UART Status Register 1, offset: 0x4 */
[...]
+ case 0x05: /**< UART Status Register 2, offset: 0x5 */
[...]
+ case 0x06: /**< UART Control Register 3, offset: 0x6 */
[...]
+ case 0x07: /**< UART Data Register, offset: 0x7 */
[...]
+ case 0x08: /**< UART Match Address Registers 1, offset: 0x8 */
[...]
+ case 0x09: /**< UART Match Address Registers 2, offset: 0x9 */
[...]
+ case 0x0A: /**< UART Control Register 4, offset: 0xA */
[...]
+ case 0x0B: /**< UART Control Register 5, offset: 0xB */
[...]
+ case 0x0C: /**< UART Extended Data Register, offset: 0xC */
[...]
+ case 0x0D: /**< UART Modem Register, offset: 0xD */
[...]
+ case 0x0E: /**< UART Infrared Register, offset: 0xE */
[...]
+ case 0x10: /**< UART FIFO Parameters, offset: 0x10 */
[...]
+ case 0x11: /**< UART FIFO Control Register, offset: 0x11 */
[...]
+ case 0x12: /**< UART FIFO Status Register, offset: 0x12 */
[...]
+ case 0x13: /**< UART FIFO Transmit Watermark, offset: 0x13 */
[...]
+ case 0x14: /**< UART FIFO Transmit Count, offset: 0x14 */
[...]
+ case 0x15: /**< UART FIFO Receive Watermark, offset: 0x15 */
[...]
+ case 0x16: /**< UART FIFO Receive Count, offset: 0x16 */
[...]
+ case 0x18: /**< UART 7816 Control Register, offset: 0x18 */
[...]
+ case 0x19: /**< UART 7816 Interrupt Enable Register, offset: 0x19 */
[...]
+ case 0x1A: /**< UART 7816 Interrupt Status Register, offset: 0x1A */
[...]
+ case 0x1B: /**< UART 7816 Wait Parameter Register, offset: 0x1B */
[...]
+ case 0x1C: /**< UART 7816 Wait N Register, offset: 0x1C */
[...]
+ case 0x1D: /**< UART 7816 Wait FD Register, offset: 0x1D */
[...]
+ case 0x1E: /**< UART 7816 Error Threshold Register, offset: 0x1E */
[...]
+ case 0x1F: /**< UART 7816 Transmit Length Register, offset: 0x1F */
[...]
+ default:
ERROR: switch and case should be at the same indent
#1532: FILE: hw/arm/kinetis/k64/peripheral/uart.c:220:
+ switch (offset) {
+ case 0x00: /**< UART Baud Rate Registers: High, offset: 0x0 */
[...]
+ case 0x01: /**< UART Baud Rate Registers: Low, offset: 0x1 */
[...]
+ case 0x02: /**< UART Control Register 1, offset: 0x2 */
[...]
+ case 0x03: /**< UART Control Register 2, offset: 0x3 */
[...]
+ case 0x04: /**< UART Status Register 1, offset: 0x4 */
[...]
+ case 0x05: /**< UART Status Register 2, offset: 0x5 */
[...]
+ case 0x06: /**< UART Control Register 3, offset: 0x6 */
[...]
+ case 0x07: /**< UART Data Register, offset: 0x7 */
[...]
+ case 0x08: /**< UART Match Address Registers 1, offset: 0x8 */
[...]
+ case 0x09: /**< UART Match Address Registers 2, offset: 0x9 */
[...]
+ case 0x0A: /**< UART Control Register 4, offset: 0xA */
[...]
+ case 0x0B: /**< UART Control Register 5, offset: 0xB */
[...]
+ case 0x0C: /**< UART Extended Data Register, offset: 0xC */
[...]
+ case 0x0D: /**< UART Modem Register, offset: 0xD */
[...]
+ case 0x0E: /**< UART Infrared Register, offset: 0xE */
[...]
+ case 0x10: /**< UART FIFO Parameters, offset: 0x10 */
[...]
+ case 0x11: /**< UART FIFO Control Register, offset: 0x11 */
[...]
+ case 0x12: /**< UART FIFO Status Register, offset: 0x12 */
[...]
+ case 0x13: /**< UART FIFO Transmit Watermark, offset: 0x13 */
[...]
+ case 0x14: /**< UART FIFO Transmit Count, offset: 0x14 */
[...]
+ case 0x15: /**< UART FIFO Receive Watermark, offset: 0x15 */
[...]
+ case 0x16: /**< UART FIFO Receive Count, offset: 0x16 */
[...]
+ case 0x18: /**< UART 7816 Control Register, offset: 0x18 */
[...]
+ case 0x19: /**< UART 7816 Interrupt Enable Register, offset: 0x19 */
[...]
+ case 0x1A: /**< UART 7816 Interrupt Status Register, offset: 0x1A */
[...]
+ case 0x1B: /**< UART 7816 Wait Parameter Register, offset: 0x1B */
[...]
+ case 0x1C: /**< UART 7816 Wait N Register, offset: 0x1C */
[...]
+ case 0x1D: /**< UART 7816 Wait FD Register, offset: 0x1D */
[...]
+ case 0x1E: /**< UART 7816 Error Threshold Register, offset: 0x1E */
[...]
+ case 0x1F: /**< UART 7816 Transmit Length Register, offset: 0x1F */
[...]
+ default:
ERROR: trailing whitespace
#1611: FILE: hw/arm/kinetis/k64/peripheral/uart.c:299:
+ $
ERROR: space required before the open brace '{'
#1612: FILE: hw/arm/kinetis/k64/peripheral/uart.c:300:
+ if (s->RCFIFO == 0){
ERROR: do not use C99 // comments
#1613: FILE: hw/arm/kinetis/k64/peripheral/uart.c:301:
+ return 1; //Can read a byte
ERROR: space required after that close brace '}'
#1614: FILE: hw/arm/kinetis/k64/peripheral/uart.c:302:
+ }else{
ERROR: do not use C99 // comments
#1615: FILE: hw/arm/kinetis/k64/peripheral/uart.c:303:
+ return 0; //Cannot read a byte
ERROR: trailing whitespace
#1622: FILE: hw/arm/kinetis/k64/peripheral/uart.c:310:
+ $
ERROR: space required before the open brace '{'
#1623: FILE: hw/arm/kinetis/k64/peripheral/uart.c:311:
+ if (size > 0){
ERROR: space required before the open brace '{'
#1624: FILE: hw/arm/kinetis/k64/peripheral/uart.c:312:
+ if (buf != NULL){
ERROR: trailing whitespace
#1649: FILE: hw/arm/kinetis/k64/peripheral/uart.c:337:
+ $
ERROR: adding a line without newline at end of file
#1681: FILE: hw/arm/kinetis/k64/peripheral/uart.c:369:
+type_init(kinetis_k64_uart_register_types)
ERROR: do not set execute permissions for source files
#1684: FILE: include/hw/arm/kinetis/k64/peripheral/flextimer.h
ERROR: trailing whitespace
#1699: FILE: include/hw/arm/kinetis/k64/peripheral/flextimer.h:11:
+ $
ERROR: space required after that close brace '}'
#1725: FILE: include/hw/arm/kinetis/k64/peripheral/flextimer.h:37:
+ }CONTROLS[8];
ERROR: trailing whitespace
#1745: FILE: include/hw/arm/kinetis/k64/peripheral/flextimer.h:57:
+ uint32_t PWMLOAD; /**< FTM PWM Load, offset: 0x98 */ $
ERROR: trailing whitespace
#1746: FILE: include/hw/arm/kinetis/k64/peripheral/flextimer.h:58:
+ $
ERROR: adding a line without newline at end of file
#1750: FILE: include/hw/arm/kinetis/k64/peripheral/flextimer.h:62:
+#endif
ERROR: do not set execute permissions for source files
#1753: FILE: include/hw/arm/kinetis/k64/peripheral/mcg.h
ERROR: trailing whitespace
#1768: FILE: include/hw/arm/kinetis/k64/peripheral/mcg.h:11:
+ $
ERROR: trailing whitespace
#1799: FILE: include/hw/arm/kinetis/k64/peripheral/mcg.h:42:
+ uint8_t C8; /**< MCG Control 8 Register, offset: 0xD */ $
ERROR: trailing whitespace
#1800: FILE: include/hw/arm/kinetis/k64/peripheral/mcg.h:43:
+ $
ERROR: adding a line without newline at end of file
#1804: FILE: include/hw/arm/kinetis/k64/peripheral/mcg.h:47:
+#endif
ERROR: do not set execute permissions for source files
#1807: FILE: include/hw/arm/kinetis/k64/peripheral/pmux.h
ERROR: trailing whitespace
#1822: FILE: include/hw/arm/kinetis/k64/peripheral/pmux.h:11:
+ $
ERROR: trailing whitespace
#1841: FILE: include/hw/arm/kinetis/k64/peripheral/pmux.h:30:
+ $
ERROR: trailing whitespace
#1879: FILE: include/hw/arm/kinetis/k64/peripheral/pmux.h:68:
+ uint32_t DFWR; /**< Digital Filter Width Register, offset: 0xC8 */
$
ERROR: trailing whitespace
#1880: FILE: include/hw/arm/kinetis/k64/peripheral/pmux.h:69:
+ $
ERROR: adding a line without newline at end of file
#1884: FILE: include/hw/arm/kinetis/k64/peripheral/pmux.h:73:
+#endif
ERROR: do not set execute permissions for source files
#1887: FILE: include/hw/arm/kinetis/k64/peripheral/sim.h
ERROR: trailing whitespace
#1902: FILE: include/hw/arm/kinetis/k64/peripheral/sim.h:11:
+ $
ERROR: trailing whitespace
#1943: FILE: include/hw/arm/kinetis/k64/peripheral/sim.h:52:
+ uint32_t UIDL; /**< Unique Id Register Low, offset: 0x1060 */ $
ERROR: adding a line without newline at end of file
#1947: FILE: include/hw/arm/kinetis/k64/peripheral/sim.h:56:
+#endif
ERROR: do not set execute permissions for source files
#1950: FILE: include/hw/arm/kinetis/k64/peripheral/uart.h
ERROR: trailing whitespace
#1965: FILE: include/hw/arm/kinetis/k64/peripheral/uart.h:11:
+ $
ERROR: trailing whitespace
#2018: FILE: include/hw/arm/kinetis/k64/peripheral/uart.h:64:
+ $
ERROR: trailing whitespace
#2023: FILE: include/hw/arm/kinetis/k64/peripheral/uart.h:69:
+static inline DeviceState *kinetis_k64_uart_create(hwaddr addr, qemu_irq irq, $
ERROR: adding a line without newline at end of file
#2039: FILE: include/hw/arm/kinetis/k64/peripheral/uart.h:85:
+#endif
total: 215 errors, 3 warnings, 1941 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0, gabriel291075, 2017/10/19
- Re: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0, Peter Maydell, 2017/10/19
- Re: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0,
no-reply <=
- Re: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0, Philippe Mathieu-Daudé, 2017/10/20
- Re: [Qemu-devel] [PATCH v1] arm: Adding new arm machine, Kinetis K64 MK64FN1M0, Philippe Mathieu-Daudé, 2017/10/20