Re: [Qemu-devel] [PATCH] build: disable -Wmissing-braces on older compilers

[Paolo Bonzini]

On 20/10/2017 12:27, Laszlo Ersek wrote:
>> +if compile_object "-Werror" "" ; then
>> +  :
>> +else
> Is this an established idiom for the configure script, in place of:
> 
>   if ! compile_object "-Werror" "" ; then
> 
> ?
> 
> Looks good to me otherwise.

I tend not use "if !".  In general that's just me, but in this case I
think it's useful to point out that a successful compile does nothing;
generally it's the successful compile that adjusts command line arguments.

Paolo