[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-pr-helper: Do not use {0} for initializati
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu-pr-helper: Do not use {0} for initialization |
|
Date: |
Mon, 23 Oct 2017 19:05:32 +0200 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Oct 20, 2017 at 01:21:21PM +0200, Paolo Bonzini wrote:
> The first field in struct dm_ioctl is an array, and old GCC warns
> about it with -Wmissing-braces (GCC <= 4.8). The "{0}" universal
> zero initializer is only useful if the other side might be a scalar;
> for a struct, "{}" is enough and shuts up the compiler.
>
> Suggested-by: Peter Maydell <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> scsi/qemu-pr-helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>