[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] hmp: introduce 'writeconfig' command
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] hmp: introduce 'writeconfig' command |
Date: |
Tue, 24 Oct 2017 11:41:01 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Vadim Galitsyn (address@hidden) wrote:
> Add 'writeconfig' command for HMP monitor. This command is a
> sibling of QMP command 'writeconfig'.
>
> This is a simple way to keep track of current state of VM
> after series of hotplugs and/or hotunplugs of different devices.
>
> Signed-off-by: Vadim Galitsyn <address@hidden>
> Signed-off-by: Eduardo Otubo <address@hidden>
> Cc: Dr. David Alan Gilbert <address@hidden>
> Cc: address@hidden
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hmp.h | 1 +
> hmp.c | 9 +++++++++
> hmp-commands.hx | 17 +++++++++++++++++
> 3 files changed, 27 insertions(+)
>
> diff --git a/hmp.h b/hmp.h
> index 3605003e4c..2730b7f7b9 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -146,5 +146,6 @@ void hmp_info_ramblock(Monitor *mon, const QDict *qdict);
> void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict);
> void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict);
> void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict);
> +void hmp_writeconfig(Monitor *mon, const QDict *qdict);
>
> #endif
> diff --git a/hmp.c b/hmp.c
> index ec61329ebb..20af8ab870 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -2901,3 +2901,12 @@ void hmp_info_memory_size_summary(Monitor *mon, const
> QDict *qdict)
> }
> hmp_handle_error(mon, &err);
> }
> +
> +void hmp_writeconfig(Monitor *mon, const QDict *qdict)
> +{
> + const char *file = qdict_get_str(qdict, "file");
> + Error *err = NULL;
> +
> + qmp_writeconfig(file, &err);
> + hmp_handle_error(mon, &err);
> +}
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 1941e19932..98a3dc4b66 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1858,6 +1858,23 @@ ETEXI
> .sub_table = info_cmds,
> },
>
> + {
> + .name = "writeconfig",
> + .args_type = "file:F",
> + .params = "file",
> + .help = "dump current configuration into specified file",
> + .cmd = hmp_writeconfig,
> + },
> +
> +STEXI
> address@hidden writeconfig @var{file}
> address@hidden writeconfig
> +Dump current configuration into specified @var{file}.
> address@hidden
> +(qemu) writeconfig /tmp/qemu.conf
> address@hidden example
> +ETEXI
> +
> STEXI
> @end table
> ETEXI
> --
> 2.13.1.394.g41dd433
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] QMP, HMP: introduce 'writeconfig' command, Vadim Galitsyn, 2017/10/23
- [Qemu-devel] [PATCH 1/4] qmp: introduce 'writeconfig' command, Vadim Galitsyn, 2017/10/23
- [Qemu-devel] [PATCH 2/4] hmp: introduce 'writeconfig' command, Vadim Galitsyn, 2017/10/23
- [Qemu-devel] [PATCH 3/4] tests: test-hmp: extend with 'writeconfig' command, Vadim Galitsyn, 2017/10/23
- [Qemu-devel] [PATCH 4/4] tests: test-hmp: print command execution result, Vadim Galitsyn, 2017/10/23
- Re: [Qemu-devel] QMP, HMP: introduce 'writeconfig' command, Dr. David Alan Gilbert, 2017/10/24