[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines
|
From: |
Christian Borntraeger |
|
Subject: |
Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines |
|
Date: |
Wed, 25 Oct 2017 07:55:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
Collin,
can you take care of the comments and send out a new version?
On 10/20/2017 03:48 PM, Farhan Ali wrote:
>
>
> On 10/20/2017 07:02 AM, Christian Borntraeger wrote:
>> --- a/pc-bios/s390-ccw/sclp.c
>> +++ b/pc-bios/s390-ccw/sclp.c
>> @@ -83,7 +83,7 @@ long write(int fd, const void *str, size_t len)
>> return -EIO;
>> }
>>
>> - for (p = str; *p; ++p) {
>> + for (p = str; len ; ++p, len--) {
>> if (data_len > SCCB_DATA_LEN - 1) {
>> return -EFBIG;
>> }
>>
>>
>>
> The write function returns len, wouldn't this change make write return 0?
Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines, Cornelia Huck, 2017/10/20
Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines, Halil Pasic, 2017/10/20