Re: [Qemu-devel] [PATCH 5/6] Minor clean-up of can_pcm3680_pci.

[KONRAD Frederic]

The same than the previous patch.

Fred

On 10/25/2017 01:29 AM, address@hidden wrote:
> From: Deniz Eren <address@hidden>
>
> Signed-off-by: Pavel Pisa <address@hidden>
> ---
>   hw/can/can_pcm3680_pci.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/hw/can/can_pcm3680_pci.c b/hw/can/can_pcm3680_pci.c
> index bc6b164ea7..692aab6ab8 100644
> --- a/hw/can/can_pcm3680_pci.c
> +++ b/hw/can/can_pcm3680_pci.c
> @@ -255,8 +255,7 @@ static void pcm3680i_pci_exit(PCIDevice *pci_dev)
>       qemu_unregister_reset(pcm3680i_pci_reset, d);
>   
>       /*
> -     * regions d->s5920_io, d->sja_io and d->xilinx_io
> -     * are destroyed by QOM now
> +     * region d->sja_io is destroyed by QOM now
>        */
>       /* memory_region_destroy(&d->sja_io[0]); */
>       /* memory_region_destroy(&d->sja_io[1]); */
> @@ -308,8 +307,8 @@ static void pcm3680i_pci_class_init(ObjectClass *klass, 
> void *data)
>       k->device_id = PCM3680i_PCI_DEVICE_ID1;
>       k->revision = 0x00;
>       k->class_id = 0x000c09;
> -    k->subsystem_vendor_id = 0x13fe;
> -    k->subsystem_id = 0xc002;
> +    k->subsystem_vendor_id = PCM3680i_PCI_VENDOR_ID1;
> +    k->subsystem_id = PCM3680i_PCI_DEVICE_ID1;
>       dc->desc = "Pcm3680i PCICANx";
>       dc->props = pcm3680i_pci_properties;
>       dc->vmsd = &vmstate_pcm3680i_pci;